ShanoirUploader: auto test import + perf optimization QueryPACSService

[michaelkain]

• all imports: fixes for images==null issues in MS import + fixes for index == null issues in ms datasets
• ofsep issue: new contrast agent used enum value added
• increase version of dcm4che3
• query pacs: performance booster: stop opening a new network connection for hundreds of c-finds, depending on the query result, per search criteria
• ShUp: final fix for import-from-pacs, after refactoring
• ShUp: final fix for import-from-files, after refactoring
• ShUp: query pacs: now default of enter button on keyboard, to avoid mouse usage
• ShUp: new feature: configure default profile for ShUp to avoid asking the user at every start up, in basic.properties
• adjust StudyApiController: add current user as StudyUser, in case of empty StudyUserList
• ShUp: includes creation of study from within ShUp

[michaelkain]

Hi @jcomedouteau, this PR could be interesting for the new release, as it should dramatically increase the query time on import-from-pacs. I tested locally. Maybe you could have a look on qualif? with this PR if import-from-pacs works and is faster. It will be interesting to see, if after some hours, it still works. I have not found what timeout is applied on the socket connection... With kind regards and happy reading and testing, Michael

[jcomedouteau]

I'm on it :)

[jcomedouteau]

On qualif, I can't request for the PACS with 'test':

2023-10-19T14:06:57.642+02:00 INFO 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Calling PACS, C-FIND with level: PATIENT
2023-10-19T14:06:57.643+02:00 INFO 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Tag: PatientName, Value: [test]
2023-10-19T14:06:57.643+02:00 INFO 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Tag: PatientID, Value: []
2023-10-19T14:06:57.643+02:00 INFO 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Tag: PatientBirthDate, Value: []
2023-10-19T14:06:57.643+02:00 INFO 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Tag: PatientBirthName, Value: []
2023-10-19T14:06:57.643+02:00 INFO 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Tag: PatientSex, Value: []
2023-10-19T14:06:57.643+02:00 ERROR 1 --- [http-nio-9903-exec-1] o.s.n.i.dicom.query.QueryPACSService : Error in c-find query:

java.io.EOFException: null
at org.dcm4che3.util.StreamUtils.readFully(StreamUtils.java:69)
at org.dcm4che3.net.PDUDecoder.readFully(PDUDecoder.java:225)
at org.dcm4che3.net.PDUDecoder.nextPDU(PDUDecoder.java:159)
at org.dcm4che3.net.Association$2.run(Association.java:520)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)

I think you can set a timeout in the connection configuration, but it's hard to say which one we need to configure..

[michaelkain]

Hi @jcomedouteau, locally the new query impl. with connect + release, works fine. I tested with import-from-pacs web GUI. It works as well in ShUp (echo + find), locally.

[jcomedouteau]

Working well for the moment, I'll test in ~1h (even if the logic has changed, just to be sure), and we'll be OK.