Quality control fixes and enhancements #1851
Conversation
julien-louis
force-pushed
the
quality-by-exam
branch
from
ded409c to
f13765f
Compare
julien-louis
changed the title
|
done |
|
|
Hi Julien, I hope you are doing fine. My tests on qualif, when I use apply, do not produce any tags in the tree. Could you please as soon as possible have a look on that? When I click on the task detail in the jobs list, I do not have access to the quality report. Is this wanted? |
|
Thank you for your fast answer, you are completely right, my conditions where too strict and no exam was valid, that is why I did not have a tag. |
|
Hi @julien-louis, thank you for the stack trace. As discussed, please fix the NPE related to org.shanoir.ng.shared.event.ShanoirEvent["report"]), that blocks imports. Thank you and with kind regards, Michael |
|
Hi Julien, please see my screenshot attached. |
|
I couldn't import sample.zip in my new empty study test julien 2 : qc : |
|
have you tested with an existing exam, or a new created one? |
|
I tested with an existing exam, that had already only t1 inside, so I took an exam, I had created during my previous import. I would expect the QC to check only my DICOM study I am about to import, and not the already imported exam |
|
|
|
@michaelkain actually the empty study card message was about empty quality cards, I changed the message. I don't know what to do with an empty quality card. Return an empty report ? |
|
@michaelkain Ok I checked and you are right, I think at import the quality control is on the whole exam, not just the imported data. I will assert that immediately. |
| } | ||
| } | ||
| return qualityResult; | ||
| } | ||
|
|
||
| private QualityCardResult checkQuality(Examination examination, Set<DatasetAcquisition> limitToTheseAcquisitions, ImportJob importJob) throws ShanoirException { | ||
| // save the exam acquisitions | ||
| List<DatasetAcquisition> saveList = new ArrayList<>(); |
There was a problem hiding this comment.
Hi Julien, thank you for your corrections. I am wondering about the below code. The ImporterService is only responsible for new-imported-data (either on a new and empty exam or an existing exam). The below code is really quite a work-around (sorry for the word), but putting existing acquisitions into memory, simulate a new exam and then putting back the old acquisitions, is really strange. I have fear in two months we will not understand the code ourselves. Please let's discuss this and how we continue from here. Thank you and with kind regards, Michael
|
Hi, I have a new issue during my tests. The dates are corrupted somehow in the report table in the frontend and in the csv, please see my screenshot. With kind regards, Michael |
|
Thank you for the time added to the tasks table! Very useful! |
There was a problem hiding this comment.
Hi Julien,
my tests on qualif are looking fine now. We will plan the refactor for 2024, see my last comment. I approve. See below my test result, with kind regards, Michael
QC rule created, on study demonstration:
Quality rule, that requires at least one T1,t1 serie in the metadata of shanoir
TEST: test button used: correct results, apply button used: correct results: OK
--- IMPORT-TESTS:
TEST: import quality conform serie, into new subject, new exam: OK, import worked
t1 phantom serie used, new subject + exam created during import
TEST: use quality rule conform serie, into existing exam, that is not quality-conform: OK, import worked
1 serie selected, that is t1_fl2d_tra_3mm mtc 10/08/2009 MR
Use subject TestMK20210107-01, that has existing exam CT chest plan
TEST: use serie, not quality-conform, into existing exam, that is quality-conform: OK, import refused
1 serie selected tse_vfl_WIP607 04/03/2010 MR, not qc conform
into existing exam selected with one serie, qc conform
No description provided.