Merge pull request #47 from fledge-iot/FOGL-9094

FOGL-9094: skip duplicate entry in outstation list

dnp3.cpp

@@ -63,6 +63,8 @@ bool DNP3::start()
 
 	this->unlockConfig();
 
+	Logger::getLogger()->info("Found %d DNP3 TCP outstation configured", m_outstations.size());
+
 	// Iterate outstation array
 	for (OutStationTCP *outstation : m_outstations)
 	{

include/south_dnp3.h

@@ -110,6 +110,21 @@ class DNP3
 		// Add outstation
 		void	addOutStationTCP(OutStationTCP *outstation)
 		{
+			for (OutStationTCP *o : m_outstations)
+			{
+				if (o->linkId == outstation->linkId &&
+				    o->port == outstation->port &&
+				    o->address == outstation->address)
+				{
+					Logger::getLogger()->error("Skip outstation entry in the list as an outstation " \
+							"already exists with address %s, port %d and linkId %d",
+							outstation->address.c_str(),
+							outstation->port,
+							outstation->linkId);
+					return;
+				}
+			}
+
 			m_outstations.push_back(outstation);	
 		};