Feature/add add monument workflow cypress tests #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes the url to the full localhost url. This is done so the tests can actually get to the point where they run as uncaught issues were otherwise blocking them before they even got started. We can debug this later
Ignores videos and screenshots generated from cypress studio
Also adds comments and sections off different tabs in the code
Also changes the url to the full localhost url. This is done so the tests can actually get to the point where they run as uncaught issues were otherwise blocking them before they even got started. We can debug this later
Ignores videos and screenshots generated from cypress studio
Also adds comments and sections off different tabs in the code
also renames tests to run in order
…l/coral-arches into feature/cypress-tests
also renames tests
…fusion id and bu fusion id
andrea-kyurchiev
requested changes
Sep 18, 2024
There was a problem hiding this comment.
There were no markings in the sheet. A lot of the same issues as flagged in the previous PRs:
- Selecting random elements for relationships instead of created ones
- Not having any tests for the rich textboxes
- Items just getting clicked and nothing being done after with no comment or explanation
- Output not getting verified
- Includes changes from other PRs
Applicable to the other tests as well some comments would've been nice where things don't seem clear at a first glance.
| // Start tab | ||
| cy.wait(4000); | ||
| cy.get('.card_component.resourceid').contains('HA Number'); | ||
| cy.get('.form-control').should('be.disabled'); |
There was a problem hiding this comment.
Proper disabled check, there should also be a check here that this field is actually populated
| cy.get('.card_component.category_type').contains('Select an option').click(); | ||
| cy.wait(2000); | ||
| cy.get('.select2-results__option').first().click(); | ||
| cy.get('.card_component.category_type > .row > .form-group > .col-xs-12 > .select2 > .selection > .select2-selection > .select2-selection__rendered > .select2-selection__clear').first().click({force:true}); |
There was a problem hiding this comment.
Checks if the X is clickable but doesnt check if if does anything once clicked
| cy.get('.select2-selection__rendered').contains('Select an option').click(); | ||
|
|
||
| cy.get('.select2-results__option').contains('Approx').click(); | ||
| cy.get('.select2-selection__rendered > .select2-selection__clear').first().click({force: true}); |
There was a problem hiding this comment.
Checks if clear is clickable but doesnt check results
| cy.wait(2000); | ||
| cy.get('[aria-label="Postcode"]').first().click().type('Testing Labs'); | ||
| cy.wait(2000); | ||
| cy.get('.county_selected').contains('Select an option').scrollIntoView().click(); |
There was a problem hiding this comment.
What is the intended result here?
| cy.wait(2000) | ||
| cy.get('.bibliographic_source_citation').contains('Add new Relationship').click(); | ||
| cy.wait(2000); | ||
| cy.get('.select2-results__option').first().click(); |
There was a problem hiding this comment.
Again, this should've been added to the prerequisite tests similar to create person etc. Shouldn't use a random record as this wouldn't be present in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress tests for Add Monument workflow.
Not covered Fully is the file upload and map tabs will have to potentially be manually tested as they have been quick tricky
Spreadsheet attached
https://docs.google.com/spreadsheets/d/1C1ctkKZdIIUjVUsPxAQOL-HQN3VMxsLEquoysLvVKBk/edit?hl=en_GB&pli=1&gid=1328095868#gid=1328095868
Flag for enforcement branch will need to merge 1st (Andreas)
I've left a in progress in the spreedsheet as after lunch cypress starts playing up so havent fully been able to verify that everything is covered. I have E2E for the fully flow (happy path) and I've also completed individual tests for each tab of the flow