Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/emerald/36/domain value view model #12

Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft

Feature/emerald/36/domain value view model #12

wants to merge 59 commits into from

Conversation

OwenGalvia
Copy link
Collaborator

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Arches ORM currently has no Domain Value or Domain Value List types.
This prevents users form getting human readable values from nodes with these datatypes.
This PR provides a DomainValueViewModel for the Arches-Django adapter.

Checklist

  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch
  • Unit tests pass locally with my changes

philtweir and others added 30 commits May 27, 2024 18:43
@philtweir
fix(api): resolve issues where the API was not sending/receiving with…
15cc7db 
… correction transformations
@philtweir
chore: ruff fixes
651020c
@philtweir
fix: if no period in target, continue working
9c220a2
@philtweir
fix: spot missing/wrong graphs
583ecc6
@philtweir
fix: trigger loading of API on start, not request
c0360aa
@philtweir
fix(graphql): make unset values none in api
acd3ebf
@philtweir
fix: differences between model_class and model_class_name
f019248
@philtweir
fix: work better with (single) related models
a01d67d
@philtweir
fix: add model reloading
f162648
@philtweir
feat: remove from node lists
745e64b
@philtweir
fix: ensure ghost children are working correctly
3047b3c
@taylorn01
fix: the django group coming back was a tuple with (group, bool) I've…
86f1d1e 
… seen this with django queries the bool is the success of the query. Tests seemed to pass after this change
@taylorn01
chore: remove logs
46561e9
@philtweir
wip: explicit traceback
632622f
@philtweir
fix: ensure that the tile-saving happens in a transaction so we do no…
f9ba571 
…t try to save a tile before its parent
@philtweir
fix: remapping broken if against a root field
2435720
@taylorn01
Merge pull request #6 from flaxandteal/fix/group-returning-as-tuple
6a648ab 
Fix/group returning as tuple
@philtweir
fix: removes all DB calls on class init by calling _build_nodes only …
3ffeb96 
…on demand
@philtweir
chore: fix ruff
17b13b8
@philtweir
Merge pull request #7 from flaxandteal/fix/do-not-hit-db-on-import
514d8bf 
Do not hit db on import
@philtweir
feat: add alpha-level endpoints for concept and resource models, requ…
d41537d 
…iring superuser
@philtweir
chore: fix ruff
27595ba
@philtweir
Merge pull request #8 from flaxandteal/feat/add-other-endpoints
229050b 
Add Concept and Resource Model endpoints
@philtweir
fix: do not raise an exception if the user or group is missing, but d…
51519ab 
…o warn
@philtweir
feat: add geojson datatype
4e918e4
@philtweir
fix: better debug for missing related resources
afd64bc
@philtweir
fix: better context-free debugging
a04cafc
@philtweir
chore: fix ruff
5e93551
@philtweir
fix: extra protections against ghost resources
571d3cb
@philtweir
fix: stop str(...) raising DescriptorsNotYetSet
c01d13e
@philtweir
chore: fix CI
da0cc59
@philtweir
chore: fix CI
f3fe10a
@philtweir
feat(rdm): basic rdm
96ac30c
@philtweir
feat: support 3.9
c9cbfaf
@philtweir
fix(concepts): take care of none case
40ce2a9
@philtweir
fix(concepts): align arches_django with static
71b93ce
@philtweir
fix(rdm): ensure semantic nodes bind closures correctly
ae34c90
@philtweir
fix: improve debug output
d4b570e
@philtweir
fix: ensure right child nodes loaded
ecceb82
@philtweir
fix(tests): ensure User is cardinality 1
c2156bb
@philtweir
feat(rdm): add static concepts
d36f271
@philtweir
feat: support 3.9 for static
73a6b08
@philtweir
chore: tidy ruff
277db20
@philtweir
fix(rdm): ensure compatibility with arches_graphql_client 0.0.11
d12c948
@philtweir
fix: tests restored and made more efficient by reusing seeded data af…
df39e0d 
…ter first load
@philtweir
fix: skip concepts that have no identifier
e3d0586
@philtweir
fix(docs): tidy up doc generation
82788c6
@philtweir
fix(docs): tidy up doc generation
18072dc
@philtweir
fix(docs): basic quickstart
f30b8b7
@philtweir
fix(docs): basic quickstart
9934b97
@philtweir
feat(rdm): test creating and returning a concept is consistent
3c8e421
@philtweir
feat(rdm): make it possible to create new collections from old
4d06a32
@philtweir
fix: only attempt to load an identifier if we do not have a working UUID
ef93090
@philtweir
fix: documentation correction to ensure ORM is pulled in
3da26cf
@philtweir
fix: add test for retrieving concept id
559188c
@philtweir
feat: add method to get all collections on a model
3576f92
@philtweir
fix(arches_django): use a sentinel type for missing groups
7fae3dc
@philtweir
fix(groups): django group view model
77e081c
@OwenGalvia OwenGalvia self-assigned this Jan 29, 2025
@OwenGalvia OwenGalvia marked this pull request as draft January 29, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OwenGalvia OwenGalvia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OwenGalvia @philtweir @taylorn01