feat: removal of default security group (#44)

[flaviostutz]

Summary

Removing default security group creation as it seems an anti-pattern because it might create too many ENIs in production workloads. See #44 for more details

Breaking changes

• "allowAllOutbound" property for lambda is not supported anymore.
• "defaultSecurityGroup" attribute from NodeJS construct is not present anymore

Closing issues

Fixes #44

[MarcioMeier]

question: adding the !feat will create a new major version tag, right?
We should avoid it as we are in version 0 and not ready for version 1

[MarcioMeier]

suggestion: mutating a function parameter is bad practice, it can lead to confusion and make it harder to the caller to understand it.

As we never want to provide the network we could omit it from the customResourceConfig

const { network, ...customResourceConfig } = args.props.customResourceConfig ?? {};

or removing it from BaseNodeJsFunction props

const customResourceFunction = new BaseNodeJsFunction(args.scope, `${args.id}-custom-lambda`, {
    ...customResourceConfig,
    network: undefined,

[flaviostutz]

I agree! I was trying other alternatives but it was adding too much code. Thanks for the great suggestion!

[erik-am]

Thank you @flaviostutz for the quick action! 😄

[flaviostutz]

question: adding the !feat will create a new major version tag, right? We should avoid it as we are in version 0 and not ready for version 1

Yes, I wasn't thinking of generating a major version, but would like to stress that it's a breaking change. I am changing it so we don't generate a "1.0.0" version as you mentioned :)