-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial upsampfact tweak #638
initial upsampfact tweak #638
Conversation
This goes far above and beyond what I originally had in mind, thanks!
So whenever the benchmarks suggest to switch to 1.25 where the current code uses 2, some extra caution will be necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I am in progress testing it out.
I had a question if type 3 with tol<1e-9 is requested, does it revert to upsampfac=2 ?
Best, Alex
} | ||
|
||
// 2) Special-case for nufftType == 3 | ||
// TODO: maybe use the bandwidth here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good - let's do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should do it in setpts where nf is computed already for FFT sizes. Then choose 2.0 if FFT size will be small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postpone to another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to explain in 1-2 lines in CHANGELOG.
Also rerun FFT=DUCC and see if need to add #ifdef
THanks! Alex
I implemented an heuristic to better choose upsampling factor between 1.25 and 2.00.
I gather the data using devel/wisdom.py then I analyze with devel/analyse_upsamp.py
With that I developed the cases that go in the c++ code.