-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matlab Mexcuda support for cufinufft #634
Draft
lu1and10
wants to merge
14
commits into
flatironinstitute:master
Choose a base branch
from
lu1and10:mexcuda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f7de7ce
test mexcuda
lu1and10 f16f67b
merge master branch
lu1and10 d9d72b3
adding gpuArray check layer, to do more testing and docs
lu1and10 c5feabd
Merge branch 'flatironinstitute:master' into mexcuda
lu1and10 799d0d0
add math check matlab guru1d1, move to examples
lu1and10 6642bc6
add mwrap generated files
lu1and10 7902e38
update mex ci
lu1and10 fc25125
fix typo
lu1and10 04791db
remove isgpuarray requirement
lu1and10 bd3d619
add finufft_isgpuarray function
lu1and10 60f56f3
fix finufft_isgpuarray function
lu1and10 8805913
Merge branch 'flatironinstitute:master' into mexcuda
lu1and10 baf6e21
add back finufft_plan.m comments
lu1and10 11ec596
add some doc to cufinufft.mw and install_gpu.rst
lu1and10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't reallly need to specify the architectures as it should use native by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we don't have to. But I find it's a bit annoying compiled on my FI cluster workstation with P4000 card, later testing on v100, a100 and v100 recompiling every time, at least for cluster users compiling with different arches save some time.