Skip to content

Commit

Permalink
gpu_sionly typo in gpu impl.h; sorry for using Jenkins as a debugger;…
Browse files Browse the repository at this point in the history
… clang-format make compat w/ 14.0.0
  • Loading branch information
ahbarnett committed Feb 8, 2025
1 parent 10342bb commit ba1cc8a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Master, using release name V 2.4.0 (2/8/25)
* PR617: Caching pip dependencies in github actions.
Forcing Ninja when building python on Windows.
* PR614: Added support for sccache in github actions.
Caching cmake dependencies so to avoid downloading fftw, xsimd, etc every time.
Caching cmake dependencies so to avoid downloading fftw, xsimd, etc every time
* fully removed chkbnds option (opts and spreadopts) (Barnett)
* classic GNU makefile settings make.inc.* tidied to make-platforms/ (Barnett)
* unified separate-dim arrays (eg X,Y,Z->XYZ), simplifiying core (Reinecke #592)
Expand Down
11 changes: 6 additions & 5 deletions include/cufinufft/impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,15 @@ int cufinufft_makeplan_impl(int type, int dim, int *nmodes, int iflag, int ntran

if (type == 1 || type == 2) {
CUFINUFFT_BIGINT nf1 = 1, nf2 = 1, nf3 = 1;
if (opts.gpu_spreadinterponly) { // spread/interp grid is the user "mode" sizes
if (d_plan->opts.gpu_spreadinterponly) {
// spread/interp grid is precisely the user "mode" sizes, no upsampling
nf1 = d_plan->ms;
if (dim > 1) nf2 = d_plan->mt;
if (dim > 2) nf3 = d_plan->mu;
if (d_plan->opts.debug)
if (d_plan->opts.debug) {
printf("[cufinufft] spreadinterponly mode: (nf1,nf2,nf3) = (%d, %d, %d)\n", nf1,
nf2, nf3);
}
} else { // usual NUFFT with fine grid using upsampling
set_nf_type12(d_plan->ms, d_plan->opts, d_plan->spopts, &nf1,
d_plan->opts.gpu_obinsizex);
Expand All @@ -246,7 +248,6 @@ int cufinufft_makeplan_impl(int type, int dim, int *nmodes, int iflag, int ntran
if (d_plan->opts.debug)
printf("[cufinufft] (nf1,nf2,nf3) = (%d, %d, %d)\n", nf1, nf2, nf3);
}

d_plan->nf1 = nf1;
d_plan->nf2 = nf2;
d_plan->nf3 = nf3;
Expand Down Expand Up @@ -764,8 +765,8 @@ int cufinufft_setpts_impl(int M, T *d_kx, T *d_ky, T *d_kz, int N, T *d_s, T *d_
thrust::cuda::par.on(stream), phase_iterator, phase_iterator + N,
d_plan->deconv, d_plan->deconv,
[c1, c2, c3, d1, d2, d3, realsign] __host__ __device__(
const thrust::tuple<T, T, T> tuple,
cuda_complex<T> deconv) -> cuda_complex<T> {
const thrust::tuple<T, T, T> tuple, cuda_complex<T> deconv)
-> cuda_complex<T> {
// d2 and d3 are 0 if dim < 2 and dim < 3
const auto phase = c1 * (thrust::get<0>(tuple) + d1) +
c2 * (thrust::get<1>(tuple) + d2) +
Expand Down

0 comments on commit ba1cc8a

Please sign in to comment.