Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed setRoute behaviour #297

Closed
wants to merge 5 commits into from
Closed

fixed setRoute behaviour #297

wants to merge 5 commits into from

Conversation

merrifieldbrian
Copy link

Added splice route ability as specified in ReadMe. (#235)
Also fixed typo on line 225 where 's' is used instead of 'val'

@asazernik
Copy link

This can be squashed into one commit (since the second commit fixes a bug in the first), and I'd prefer for the check for typeof val == 'string' to only be done if the first two arguments are integers. Otherwise we'll call to splice with e.g. setRoute("some", "garbage", "arguments") and give a really unhelpful error message.

But yeah, this totally needs to be merged, especially since the documentation indicates that this behavior should already be implemented.

@merrifieldbrian
Copy link
Author

created new pr (#314) to squash extra commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants