Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change flask-api dependency to upstream develop branch #524

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

ngdio
Copy link

@ngdio ngdio commented Jan 27, 2024

For flask-api, the Pipfile points at a branch in a forked repository that no longer exists as it has been merged into upstream, causing pipenv to fail to lock. I've changed it to the upstream development branch which is where the changes can be found and properly installed.

Specified branch no longer exists as it has been merged into upstream, causing pipenv to fail to lock.
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6677f4a) 70.83% compared to head (9456892) 66.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   70.83%   66.88%   -3.95%     
==========================================
  Files          40       41       +1     
  Lines        2273     2271       -2     
  Branches      338      338              
==========================================
- Hits         1610     1519      -91     
- Misses        556      655      +99     
+ Partials      107       97      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codders
Copy link

codders commented Feb 4, 2024

Thanks for the PR! It seems like as well as changing the source of flask-api, you also updated the versions of all the other libraries, and in the latest version of pyright we have some new type issues.

If you want to submit a change for just flask-api, that would be very welcome. Otherwise I will look later on about either fixing the pyright issues or just upgrading the one library.

@ngdio
Copy link
Author

ngdio commented Feb 4, 2024

I understand, will take care of it. Though it might be best to adjust to the Pyright changes as well, keeping it to the original purpose should be good enough for now

@ngdio
Copy link
Author

ngdio commented Feb 5, 2024

I don't think there is a way to add or change a dependency in pipenv without causing the whole Pipfile.lock to update entirely. I've locked pyright to the previously used version as well as firebase-admin which seems to have had a breaking change, everything else seems to work as previously.

This should be better practice anyway, if there's anything that broke it through this the dependency should be fixed to the version it last worked in.

@codders codders merged commit 0e82ac9 into flathunters:main Feb 5, 2024
5 of 6 checks passed
@ngdio ngdio deleted the fix_flask-api_dep branch February 5, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants