Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chromedriver for kleinanzeigen #511

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Conversation

Dimfred
Copy link

@Dimfred Dimfred commented Dec 15, 2023

Hey hey,
quick and dörti hack to use chromedriver. Sry it's dirty, but I am a bit short on time lately.

Anyho, had to patch the chrome options to make it work, besides that just copy pasted the stuff from immoscout as discussed in #510.

Tested it on my side with python3.11 seems to work I guess?
If you want changes / move something from a to b to make it cleaner let me know.
LG

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f98b361) 66.40% compared to head (674d12f) 66.91%.
Report is 2 commits behind head on main.

Files Patch % Lines
flathunter/crawler/kleinanzeigen.py 78.94% 4 Missing ⚠️
flathunter/chrome_wrapper.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   66.40%   66.91%   +0.51%     
==========================================
  Files          40       40              
  Lines        2253     2270      +17     
  Branches      335      337       +2     
==========================================
+ Hits         1496     1519      +23     
+ Misses        664      653      -11     
- Partials       93       98       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - these changes look good, and they work for me. I have to say, I also tried without chromedriver and it seemed to work fine on my PC, but we've had enough reports of problems that I think it makes sense to merge this in.

@codders codders merged commit 728bab9 into flathunters:main Dec 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants