Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc url deployment association #84

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

zeroXbrock
Copy link
Member

@zeroXbrock zeroXbrock commented Jan 14, 2025

Motivation

#70

Solution

  • new rpc_urls table
  • reference rpc_url_id in named_txs table
  • filter named tx lookups by rpc_url

⚠️ Notice

This PR includes breaking changes to the DB schema. You will need to move/delete your old DB so that contender can create a new one with the proper schema. If this were in prod, we'd build in an upgrade step instead of wiping the DB, but thankfully we're not in production rn :)

# export your data if desired
contender report

# delete your old DB
rm ~/.contender/contender.db

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@dmarzzz
Copy link
Member

dmarzzz commented Jan 14, 2025

This PR includes breaking changes to the DB schema.

Could we do releases with increments to the major release when ever we do breaking changes

@zeroXbrock
Copy link
Member Author

This PR includes breaking changes to the DB schema.

Could we do releases with increments to the major release when ever we do breaking changes

as soon as we start publishing releases :)

@zeroXbrock zeroXbrock merged commit 381a7e4 into main Jan 14, 2025
5 checks passed
@zeroXbrock zeroXbrock deleted the rpc-url-deployment-association branch January 14, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants