Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix Flutter 3.29.0 analyzer issues #3492

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: Fix Flutter 3.29.0 analyzer issues #3492

merged 2 commits into from
Feb 13, 2025

Conversation

spydon
Copy link
Member

@spydon spydon commented Feb 13, 2025

Description

Fixes the analyze issues that the new flutter version triggered on.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon enabled auto-merge (squash) February 13, 2025 10:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Benchmark Results

Package flame:

Benchmarks Current Branch
[chore/fix-3.29.0-analyze-issues]		 Base Branch
[main]		 Diff
Render Components Benchmark 977.564 μs 958.364 μs 🔴 +2.003 %
Updating Components Benchmark 331486.000 μs 280701.375 μs 🔴 +18.092 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@spydon spydon merged commit 9f54a69 into main Feb 13, 2025
9 checks passed
@spydon spydon deleted the chore/fix-3.29.0-analyze-issues branch February 13, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @wolfenrain