Add search by language functionality #667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
added
the
proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #638 by @MaxDall , we need a better solution to handle different languages. This PR is a proposal for a solution to this issue. The idea is that you can tag each URLSource object, with the corresponding languages. It would be ideal to do it at URLSource level, since some publishers differentiate their sitemaps/feeds by language and we could then do the same.
Once the sources are tagged, we can then use the search functionality of the PublisherGroup which creates an internal filter only allowing access to those URLSources tagged with one of the languages, that are wanted.
Note, that I haven't yet thoroughly tested everything, I just wanted to get a working version of it, for you to have a look at and say what you think before putting too much effort into it. I would add tests and documentation in a further step.