-
-
Notifications
You must be signed in to change notification settings - Fork 702
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
15 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
**Before submitting a pull request,** please make sure the following is done: | ||
|
||
1. Fork [the repository](https://github.com/fkhadra/react-toastify) and create your branch from `master`. | ||
2. Run `yarn` in the repository root. | ||
1. Fork [the repository](https://github.com/fkhadra/react-toastify) and create your branch from `main`. | ||
2. Run `pnpm` in the repository root. | ||
3. If you've fixed a bug or added code that should be tested, add tests! | ||
4. Ensure the test suite passes (`yarn test`). | ||
5. Run `yarn start` to test your changes in the playground. | ||
4. Ensure the test suite passes (`pnpm test`). | ||
5. Run `pnpm start` to test your changes in the playground. | ||
6. Update the readme is needed | ||
7. Update the typescript definition is needed | ||
8. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier-all`). | ||
9. Make sure your code lints (`yarn lint:fix`). | ||
8. Format your code with [prettier](https://github.com/prettier/prettier) (`pnpm prettier`). | ||
9. Make sure your code lints (`pnpm lint:fix`). | ||
|
||
**Learn more about contributing [here](https://github.com/fkhadra/react-toastify/blob/master/CONTRIBUTING.md)** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters