Add trivial instances for () and Void #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Jan 10, 2025
src/Web/Internal/FormUrlEncoded.hs
Outdated
| @@ -267,6 +267,10 @@ class ToForm a where | |||
|
|
|||
| instance ToForm Form where toForm = id | |||
|
|
|||
| instance ToForm Void where toForm _ = Form HashMap.empty | |||
There was a problem hiding this comment.
You are right. Like this?
phadej
reviewed
Jan 10, 2025
| @@ -413,6 +417,8 @@ class FromForm a where | |||
|
|
|||
| instance FromForm Form where fromForm = pure | |||
|
|
|||
| instance FromForm () where fromForm _ = Right () | |||
There was a problem hiding this comment.
FromForm Void should fail.
There was a problem hiding this comment.
There is no Void here, this is ().
There was a problem hiding this comment.
Perhaps you meant to add an instance for Void that fails?
There was a problem hiding this comment.
Oh, I wrote the comment before I saw yours. On it!
There was a problem hiding this comment.
Done in: Daniel-Diaz@14a5f53
|
Any further feedback on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful when a function expects a form but no form is to be passed.
I updated the stack file because it otherwise didn't build.