Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.14.0 #136

Merged
merged 32 commits into from
Jul 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
cc3f192
Update sales receipt logic to be negative
fivetran-avinash Jun 18, 2024
04a54a2
bump schema
fivetran-avinash Jun 18, 2024
6814e3d
Update int_quickbooks__sales_receipt_double_entry.sql
mikerenderco Jun 20, 2024
bb6bba4
revert drg accounts
fivetran-avinash Jun 26, 2024
2223dcd
remove join
fivetran-avinash Jun 26, 2024
0927c89
syntax
fivetran-avinash Jun 26, 2024
95fae91
Merge pull request #131 from mikerenderco/main
fivetran-avinash Jun 26, 2024
e10bcae
regen docs, add tests, documentaton
fivetran-avinash Jun 26, 2024
7575314
dbt_project.yml
fivetran-avinash Jun 26, 2024
a39bf68
PR fixes
fivetran-avinash Jun 26, 2024
f49f442
Merge pull request #130 from fivetran/bugfix/sales-receipt-debit-shou…
fivetran-avinash Jun 26, 2024
91c99dd
Add multicurrency support to end models
fivetran-avinash Jul 8, 2024
6948e95
add multicurrency support to additional models, update documentation,…
fivetran-avinash Jul 9, 2024
f85f5a2
Bump schema
fivetran-avinash Jul 9, 2024
58df6c7
testing/documentation
fivetran-avinash Jul 16, 2024
4cf0ad9
testing/documentation
fivetran-avinash Jul 16, 2024
8156cda
CHANGELOG
fivetran-avinash Jul 16, 2024
0448f59
bump schema
fivetran-avinash Jul 16, 2024
07eb792
fix and add tests
fivetran-avinash Jul 17, 2024
7ae35c7
fix tests
fivetran-avinash Jul 17, 2024
03022b7
PR review notes
fivetran-avinash Jul 18, 2024
bffceda
fixes
fivetran-avinash Jul 18, 2024
258fdf8
schema
fivetran-avinash Jul 18, 2024
ae46b2e
final PR notes
fivetran-avinash Jul 18, 2024
03ad811
vars config
fivetran-avinash Jul 19, 2024
ac946b6
release review updates
fivetran-avinash Jul 20, 2024
044a815
regen docs
fivetran-avinash Jul 20, 2024
fe35f20
schema
fivetran-avinash Jul 22, 2024
804d155
schema
fivetran-avinash Jul 22, 2024
93bbe5d
pre-merge updates
fivetran-avinash Jul 22, 2024
e76e353
Merge pull request #134 from fivetran/feature/multicurrency-support
fivetran-avinash Jul 22, 2024
7f3a524
regen docs
fivetran-avinash Jul 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
regen docs, add tests, documentaton
fivetran-avinash committed Jun 26, 2024
commit e10bcae3457c10cff53896b8ed81f3ead80f1c50
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -4,4 +4,5 @@ dbt_modules/
logs/
.DS_Store
integration_tests/.DS_Store
dbt_packages/
dbt_packages/
env/
11 changes: 9 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
# dbt_quickbooks v0.13.2
[PR #130](https://github.com/fivetran/dbt_quickbooks/pull/130) includes the following updates:
# dbt_quickbooks v0.X.X RELEASE TO BE ANNOUNCED

This pull request includes the following updates:
## Bug Fix
- Adjusted logic for discount sales receipt lines in `int_quickbooks__sales_receipt_double_entry` model to bring in these values properly as negative adjusted amounts in the `quickbooks__general_ledger`.
[PR #130](https://github.com/fivetran/dbt_quickbooks/pull/130)

## Under the Hood
- Added consistency tests within integration tests for the `quickbooks__general_ledger` models.

## Contributors
- [@mikerenderco](https://github.com/mikerenderco ) ([PR #131](https://github.com/fivetran/dbt_quickbooks/pull/131))

# dbt_quickbooks v0.13.1
[PR #125](https://github.com/fivetran/dbt_quickbooks/pull/125) includes the following updates:
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
config-version: 2
name: 'quickbooks'

version: '0.13.2'
version: '0.13.1'

require-dbt-version: [">=1.3.0", "<2.0.0"]

2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

37 changes: 5 additions & 32 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

35 changes: 22 additions & 13 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -4,19 +4,19 @@ version: '0.13.1'

profile: 'integration_tests'
config-version: 2
models:
quickbooks:
+materialized: table
double_entry_transactions:
+materialized: table
transaction_lines:
+materialized: table
intermediate:
+materialized: table
quickbooks_source:
+materialized: table
tmp:
+materialized: view
# models:
# quickbooks:
# +materialized: table
# double_entry_transactions:
# +materialized: table
# transaction_lines:
# +materialized: table
# intermediate:
# +materialized: table
# quickbooks_source:
# +materialized: table
# tmp:
# +materialized: view
vars:
quickbooks_source:
quickbooks_schema: quickbooks_integration_tests_06
@@ -61,6 +61,15 @@ vars:
quickbooks_vendor_credit_identifier: "vendor_credit_data"
quickbooks_vendor_identifier: "vendor_data"


# For validation testing. To be commented out before release.


account_type_exclusions: ['Discount']

models:
+schema: "quickbooks_{{ var('directed_schema','dev') }}"

seeds:
+quote_columns: "{{ true if target.type == 'redshift' else false }}"
quickbooks_integration_tests:
2 changes: 1 addition & 1 deletion integration_tests/packages.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
packages:
- local: ../
- local: ../
39 changes: 39 additions & 0 deletions integration_tests/tests/consistency_general_ledger_amounts.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{{ config(
tags="fivetran_validations",
enabled=var('fivetran_validation_tests_enabled', false)
) }}

with prod as (

select
transaction_id,
sum(adjusted_amount) as adjusted_amount_cumulative
from {{ target.schema }}_quickbooks_prod.quickbooks__general_ledger
{{ "where account_type not in " ~ var('account_type_exclusions', []) ~ "" if var('account_type_exclusions', []) }}
group by 1
),

dev as (

select
transaction_id,
sum(adjusted_amount) as adjusted_amount_cumulative
from {{ target.schema }}_quickbooks_dev.quickbooks__general_ledger
{{ "where account_type not in " ~ var('account_type_exclusions', []) ~ "" if var('account_type_exclusions', []) }}
group by 1
),

final as (

select
prod.transaction_id,
prod.adjusted_amount_cumulative as prod_adjusted_amount_cumulative,
dev.adjusted_amount_cumulative as dev_adjusted_amount_cumulative
from prod
full outer join dev
on dev.transaction_id = prod.transaction_id
)

select *
from final
where abs(prod_adjusted_amount_cumulative - dev_adjusted_amount_cumulative) >= 0.01
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{{ config(
tags="fivetran_validations",
enabled=var('fivetran_validation_tests_enabled', false)
) }}

with prod as (
select
1 as join_key,
count(*) as total_transactions
from {{ target.schema }}_quickbooks_prod.quickbooks__general_ledger
group by 1
),

dev as (

select
1 as join_key,
count(*) as total_transactions
from {{ target.schema }}_quickbooks_dev.quickbooks__general_ledger
group by 1
),

final as (

select
prod.join_key,
prod.total_transactions as prod_total_transactions,
dev.total_transactions as dev_total_transactions
from prod
full outer join dev
on dev.join_key = prod.join_key
)

select *
from final
where prod_total_transactions != dev_total_transactions