bugfix/double-entry-account-joins

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: Issue #106

This PR will result in the following new package version: v0.12.1

This will not be breaking as we are only adjusting joins for the relevant double entry models. This will result in fixing and addressing a bug and should not be treated as a breaking change. It should have no impact on users who are not affected by the previously raised bug.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Bug Fixes

• Adjusted the joins within the below intermediate double entry models to be left join as opposed to an inner join. This update was necessary as there was the possibility of the respective account cte joins to return no records if this was the case, the logic could erroneously remove transactions from the record.
  • int_quickbooks__bill_payment_double_entry
  • int_quickbooks__credit_memo_double_entry
  • int_quickbooks__deposit_double_entry
  • int_quickbooks__invoice_double_entry
  • int_quickbooks__payment_double_entry

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (I also tested setting the variable for the accounts and it still worked as expected)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

Please see the respective Height ticket for details around validation efforts. This includes validations with a customer and a Hex Notebook with additional validations.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• [n/a] README updates have been applied (if applicable)
• [n/a] DECISIONLOG updates have been updated (if applicable)
• [n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🧜‍♂️

[fivetran-reneeli]

Looks good!