-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/contact list api updates #156
Feature/contact list api updates #156
Conversation
packages.yml
Outdated
# - package: fivetran/hubspot_source | ||
# version: [">=0.18.0", "<0.19.0"] | ||
|
||
- git: https://github.com/fivetran/dbt_hubspot_source.git | ||
revision: feature/contact-list-api-updates | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be updated before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz Same comments as the source, and added one more question here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with adding the new issue template!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz thanks for addressing these notes proactively! one small suggestion left but lgtm after that!
Co-authored-by: Avinash Kunnath <[email protected]>
PR Overview
This PR will address the following Issue/Feature: Issue #155
Submission Checklist
Submitter:
deprecation_tracker.yml
github template once approved in the source PR.Validation Steps: Outline how to verify the changes
consistency_test_contact_list_exclude_fields
variable to ignore new fields in the consistency tests.Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)
Focus Areas: Highlight any complex logic or queries needing special attention
Reviewer:
Changelog