Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/contact list api updates #156

Merged
merged 10 commits into from
Mar 5, 2025

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Feb 20, 2025

PR Overview

This PR will address the following Issue/Feature: Issue #155

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
    • Provide screenshots of the new fields being populated in the staging model.
    • Show validation tests are passing
    • Will add the deprecation_tracker.yml github template once approved in the source PR.
  • Provide validation details:
    • Validation Steps: Outline how to verify the changes

      • ✅ Provide screenshots of the new fields being populated in the staging model.
        • See screenshot in internal ticket.
      • ✅ Show validation tests are passing
        • Fields added to the consistency_test_contact_list_exclude_fields variable to ignore new fields in the consistency tests.
        • image
    • Testing Instructions: Clear steps for running/testing (e.g., scripts, sample data)

      • Use the variables shown in the internal ticket to test the functionality and success of these changes.
    • Focus Areas: Highlight any complex logic or queries needing special attention

      • No real major updates to callout in this PR. Mainly just documentation and ensuring the new fields in the contact_list staging model are properly documented and flow downstream in the appropriate end models.

Reviewer:

  • Confirm submission requirements are met

Changelog

  • Draft after PR approval

packages.yml Outdated
Comment on lines 2 to 7
# - package: fivetran/hubspot_source
# version: [">=0.18.0", "<0.19.0"]

- git: https://github.com/fivetran/dbt_hubspot_source.git
revision: feature/contact-list-api-updates
warn-unpinned: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be updated before merge

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review February 26, 2025 22:45
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Same comments as the source, and added one more question here.

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with adding the new issue template!

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz thanks for addressing these notes proactively! one small suggestion left but lgtm after that!

fivetran-joemarkiewicz and others added 2 commits March 4, 2025 15:54
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 7e8ba1f into main Mar 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants