Skip to content
This repository has been archived by the owner on Aug 31, 2024. It is now read-only.

Search by email function #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Search by email function #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec7c126
search by email
Feb 8, 2011
e12f8d1
allow multiword user name queries
Feb 8, 2011
4221813
extraneous /
Feb 9, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,17 @@

// Search users for `query`.
gh.user.search = function (query, callback, context) {
jsonp("user/search/" + query, callback, context);
jsonp("user/search/" + query.replace(" ", "+"), callback, context);
return this;
};

// Search users by email for `query`.
gh.user.search_email = function (query, callback, context) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, sorry for taking so long to get back to you.

I would be happy to merge this in if you rename this function to gh.user.searchByEmail.

Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do.

I made a bunch of other changes I'll kick your way as well.

On Tue, Mar 22, 2011 at 5:31 PM, fitzgen
[email protected]
wrote:

         return this;
     };

  •    // Search users by email for query.
  •    gh.user.search_email = function (query, callback, context) {

First off, sorry for taking so long to get back to you.

I would be happy to merge this in if you rename this function to gh.user.searchByEmail.

Thanks!

Reply to this email directly or view it on GitHub:
https://github.com/fitzgen/github-api/pull/1/files#r11051

jsonp("user/email/" + query, callback, context);
return this;
};


// ### Repositories

// This is the base constructor for creating repo objects. Note that this
Expand Down Expand Up @@ -322,7 +329,7 @@

// Gather line count information on the language(s) used in this repo.
gh.repo.prototype.languages = function (callback, context) {
jsonp("/repos/show/" + this.user + "/" + this.repo + "/languages",
jsonp("repos/show/" + this.user + "/" + this.repo + "/languages",
callback,
context);
return this;
Expand Down Expand Up @@ -664,4 +671,4 @@
}
);

}(window));
}(window));