This repository has been archived by the owner on May 6, 2020. It is now read-only.
Add Python 3 support #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intially generated by the automatic `2to3` converter, and then cleaned up by hand. It should be fully compatible with both Python 2.7 and Python 3+ (I tested on both). print() is now a function, octal literals need an 'o' in them, and subprocess.check_output() returns bytes, which needs to be decoded into a str before comparison.
|
Downstream Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=937264 |
|
@micahflee anything I can do to move this along? |
|
I'm keen to see this happen too. If there's any extra work needed, I'm happy to help out. |
62 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intially generated by the automatic
2to3converter, and thencleaned up by hand. It should be fully compatible with both Python 2.7
and Python 3+ (I tested on both).
print() is now a function, octal literals need an 'o' in them, and
subprocess.check_output() returns bytes, which needs to be decoded into
a str before comparison.
Python 2 goes EOL in a little over 6 months (https://pythonclock.org/), so I thought it would be a good time to add Python 3 support :)