Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Added flag for quality #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anaisabel7
Copy link

@anaisabel7 anaisabel7 commented Jun 8, 2017

A command line option to set the quality sent to the 'convert' program on exploding has been set.
The value given to quality must be an integer, but no other limitations where implemented.

Tests were not written since no unittest structure could be found in the project.

This PR should deal with issue #13

@micahflee
Copy link
Contributor

Sorry, a previous PR caused some conflicts with this one. It's simple enough though and I resolved them, but I confirmed that this didn't actually fix the problem. I took a PDF and tried exploding it with quality 10, and then tried exploding it again with quality 100, but in either case it outputs identical PNGs.

I think that maybe -quality just doesn't do what we thought it did in this context.

@anaisabel7
Copy link
Author

@micahflee Thank you for checking this 😺

@ocram
Copy link

ocram commented Dec 15, 2019

Since PNG is a lossless format, the quality option to convert doesn’t actually reduce or improve visual quality, it just controls (losless) compression with Deflate/zlib:

Instead, the density or resolution in DPI may be increased.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants