Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder iname nesting to avoid warning about priorities #4032

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Reorder iname nesting to avoid warning about priorities #4032

merged 1 commit into from
Feb 12, 2025

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Feb 11, 2025 •
edited
Loading

Description

Fixes #4027

  • Check that this doesn't cause us to raise warnings elsewhere, I don't have total confidence in the change.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8159 ran7443 passed716 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8148 ran6594 passed1554 skipped0 failed

@dsroberts dsroberts mentioned this pull request Feb 12, 2025
Closed
@connorjward connorjward marked this pull request as draft February 12, 2025 10:34
@connorjward connorjward marked this pull request as ready for review February 12, 2025 12:46
@connorjward connorjward merged commit 16df27c into master Feb 12, 2025
20 checks passed
@connorjward connorjward deleted the connorjward/fix-4027 branch February 12, 2025 12:47
ksagiyam pushed a commit that referenced this pull request Feb 16, 2025
@connorjward @ksagiyam
Reorder iname nesting to avoid warning about priorities (#4032)
f2cc64a
ksagiyam added a commit that referenced this pull request Feb 16, 2025
@ksagiyam
Revert "Reorder iname nesting to avoid warning about priorities (#4032)"
3db1e22 
This reverts commit 16df27c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: loopy "UserWarning: Cannot satisfy constraint that iname 'n' must be nested within 'layer'"
1 participant
@connorjward