Factor the riesz map out into a separate object. #3662
Conversation
| o.dat.data[:] = c.dat.data[:] | ||
| else: | ||
| solve, rhs, soln = self._solver | ||
| rhs.assign(value) |
There was a problem hiding this comment.
check whether we need to explicitly zero BCs here.
There was a problem hiding this comment.
Aparently we need to do that, #3498
There was a problem hiding this comment.
OK, so I think what that issue actually says is that solve is bugged. I think I should default the solver here to restrict=True (because that's the nice modern way of doing it) and anything else should be fixed in a separate fix to solve.
| def arguments(self): | ||
| return (self,) | ||
|
|
||
| def coefficients(self): | ||
| return () |
There was a problem hiding this comment.
These two methods are part of the BaseForm interface. I suspect this is needed because it conveniently allows the use of arguments as if they were base forms in a few places in pyadjoint. I think this suggests that, in the long term, the right thing to do is probably to have ufl.Argument as BaseForm. It mathematically makes sense as arguments map V -> V, i.e. V x V* - > R.
|
|
1 similar comment
|
| LinearVariationalProblem, Function, Cofunction) | ||
| rhs = Cofunction(self._function_space.dual()) | ||
| soln = Function(self._function_space) | ||
| lvp = LinearVariationalProblem( |
There was a problem hiding this comment.
Given that the inner product form won't ever change, I think the LVP should have constant_jacobian=True to avoid refactoring every time.
|
Is there enough information available at setup to cache the That way if the same riesz map is needed in different places where it would be cumbersome to share the |
| lvp = LinearVariationalProblem( | ||
| self._inner_product, rhs, soln, bcs=self._bcs, restrict=True, | ||
| form_compiler_parameters=self._form_compiler_parameters) | ||
| solver = LinearVariationalSolver( |
There was a problem hiding this comment.
Can we pass an optional options_prefix through to the LVS for command line options?
Description