Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Generated React Bindings #8158

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Added Generated React Bindings #8158

merged 8 commits into from
Feb 6, 2025

Conversation

maneesht
Copy link
Contributor

No description provided.

joehan
joehan reviewed Feb 5, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
joehan
joehan reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style suggestions and potential simplifications, but looking mostly good to me!

src/dataconnect/fileUtils.spec.ts Outdated Show resolved Hide resolved
src/dataconnect/fileUtils.spec.ts Outdated Show resolved Hide resolved
src/dataconnect/fileUtils.spec.ts Outdated Show resolved Hide resolved
src/init/features/dataconnect/sdk.ts Outdated Show resolved Hide resolved
src/init/features/dataconnect/sdk.ts Show resolved Hide resolved
src/init/features/dataconnect/sdk.ts Outdated Show resolved Hide resolved
src/dataconnect/fileUtils.ts Outdated Show resolved Hide resolved
@maneesht maneesht marked this pull request as ready for review February 6, 2025 01:41
@maneesht maneesht enabled auto-merge (squash) February 6, 2025 18:20
@maneesht maneesht merged commit 36b6677 into master Feb 6, 2025
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maneesht @joehan