Support node 22 #8136
Open
Support node 22 #8136
+171
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started to move Ci to node 22, but doing it piecemeal:
|
bkendall
reviewed
Feb 7, 2025
| @@ -13,7 +13,7 @@ describe("unzip", () => { | |||
| }); | |||
|
|
|||
| after(async () => { | |||
| await fs.promises.rmdir(tempDir, { recursive: true }); | |||
| await fs.promises.rm(tempDir, { recursive: true }); | |||
There was a problem hiding this comment.
just checking that this is intentional :)
bkendall
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bunch of places where our dependencies were using builtin methods that were deprecated in Node 22.
TODO before merge:
Scenarios Tested
Ran the tests, and ran through a bunch of common commands without getting deprecation notices.
Sample Commands