Fireperf web vitals #8644

bryanatkinson · 2024-11-18T22:18:27Z

Add support for capturing web vitals metrics in Firebase performance for Web (Largest Contentful Paint, Interaction to Next Paint, Cumulative Layout Shift)
Modifies export to use sendBeacon instead of fetch API, and shifts the upload time to the first time the page is hidden or unloaded.

changeset-bot · 2024-11-18T22:18:31Z

🦋 Changeset detected

Latest commit: 22a8ae5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/performance	Minor
firebase	Minor
@firebase/performance-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2024-11-18T22:30:39Z

Size Report ¹

Affected Products

@firebase/performance
Type Base (32bf021) Merge (1094997) Diff
browser 29.1 kB 30.6 kB +1.51 kB (+5.2%)
main 29.5 kB 31.1 kB +1.56 kB (+5.3%)
module 29.1 kB 30.6 kB +1.51 kB (+5.2%)
bundle
Type Base (32bf021) Merge (1094997) Diff
performance (trace) 51.8 kB 62.3 kB +10.5 kB (+20.2%)

`firebase`

Type	Base (`32bf021`)	Merge (`1094997`)	Diff
firebase-compat.js	797 kB	808 kB	+10.1 kB (+1.3%)
firebase-performance-compat.js	30.8 kB	40.9 kB	+10.1 kB (+32.7%)
firebase-performance-standalone-compat.js	93.7 kB	104 kB	+10.3 kB (+11.0%)
firebase-performance.js	35.1 kB	45.5 kB	+10.4 kB (+29.7%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/khAtsjD51r.html

google-oss-bot · 2024-11-18T22:42:36Z

Size Analysis Report ¹

Affected Products

`@firebase/performance`

`getPerformance`

Size

Type	Base (`32bf021`)	Merge (`1094997`)	Diff
size	18.0 kB	18.9 kB	+867 B (+4.8%)
size-with-ext-deps	51.7 kB	62.1 kB	+10.4 kB (+20.2%)

Dependency

Type Base (32bf021) Merge (1094997) Diff

functions

50 dependencies

addToQueue
changeInitializationStatus
configValid
convertMetricValueToInteger
createNetworkRequestEntry
createUserTimingTrace
dispatchQueueEvents
getApiKey
getAppId
getApplicationInfo
getAuthTokenPromise
getConfig
getDocumentReadyComplete
getEffectiveConnectionType
getIid
getIidPromise
getInitializationPromise
getPerformance
getProjectId
getRemoteConfig
getServiceWorkerStatus
getStoredConfig
getVisibilityState
initializePerf
isPerfInitialized
isValidCustomAttributeName
isValidCustomAttributeValue
isValidMetricName
logNetworkRequest
logTrace
mergeStrings
postToFlEndpoint
processConfig
processQueue
registerPerformance
sendEventsToFl
sendLog
sendTraceLog
serializeNetworkRequest
serializeTrace
serializer
setupApi
setupNetworkRequests
setupOobResources
setupOobTraces
setupTransportService
setupUserTimingTraces
shouldLogAfterSampling
storeConfig
transportHandler

52 dependencies

addToQueue
changeInitializationStatus
configValid
convertMetricValueToInteger
createNetworkRequestEntry
createUserTimingTrace
dispatchQueueEvents
flushLogs
flushQueuedEvents
getApiKey
getAppId
getApplicationInfo
getAuthTokenPromise
getConfig
getDocumentReadyComplete
getEffectiveConnectionType
getIid
getIidPromise
getInitializationPromise
getPerformance
getProjectId
getRemoteConfig
getServiceWorkerStatus
getStoredConfig
getVisibilityState
initializePerf
isPerfInitialized
isValidCustomAttributeName
isValidCustomAttributeValue
isValidMetricName
logNetworkRequest
logTrace
mergeStrings
postToFlEndpoint
processConfig
processQueue
registerPerformance
sendLog
sendOobTrace
sendTraceLog
serializeNetworkRequest
serializeTrace
serializer
setupApi
setupNetworkRequests
setupOobResources
setupOobTraces
setupTransportService
setupUserTimingTraces
shouldLogAfterSampling
storeConfig
transportHandler

+ flushLogs
+ flushQueuedEvents
+ sendOobTrace
- sendEventsToFl

variables

46 dependencies

ATTRIBUTE_FORMAT_REGEX
CONFIG_EXPIRY_LOCAL_STORAGE_KEY
CONFIG_LOCAL_STORAGE_KEY
COULD_NOT_GET_CONFIG_MSG
DEFAULT_CONFIGS
DEFAULT_ENTRY_NAME
DEFAULT_REMAINING_TRIES
DEFAULT_SEND_INTERVAL_MS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
FID_WAIT_TIME_MS
FIRST_CONTENTFUL_PAINT_COUNTER_NAME
FIRST_INPUT_DELAY_COUNTER_NAME
FIRST_PAINT_COUNTER_NAME
FIS_AUTH_PREFIX
INITIAL_SEND_TIME_DELAY_MS
MAX_ATTRIBUTE_NAME_LENGTH
MAX_ATTRIBUTE_VALUE_LENGTH
MAX_EVENT_COUNT_PER_REQUEST
MAX_METRIC_NAME_LENGTH
OOB_TRACE_PAGE_LOAD_PREFIX
REMOTE_CONFIG_SDK_VERSION
RESERVED_ATTRIBUTE_PREFIXES
RESERVED_AUTO_PREFIX
SDK_VERSION
SERVICE
SERVICE_NAME
TRACE_MEASURE_PREFIX
TRACE_START_MARK_PREFIX
TRACE_STOP_MARK_PREFIX
VisibilityState
apiInstance
consoleLogger
factory
iid
initializationPromise
initializationStatus
isTransportSetup
logger
name
oobMetrics
queue
remainingTries
settingsServiceInstance
version
windowInstance

54 dependencies

ATTRIBUTE_FORMAT_REGEX
CONFIG_EXPIRY_LOCAL_STORAGE_KEY
CONFIG_LOCAL_STORAGE_KEY
COULD_NOT_GET_CONFIG_MSG
CUMULATIVE_LAYOUT_SHIFT_ATTRIBUTE_NAME
CUMULATIVE_LAYOUT_SHIFT_METRIC_NAME
DEFAULT_CONFIGS
DEFAULT_ENTRY_NAME
DEFAULT_REMAINING_TRIES
DEFAULT_SEND_INTERVAL_MS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
FIRST_CONTENTFUL_PAINT_COUNTER_NAME
FIRST_INPUT_DELAY_COUNTER_NAME
FIRST_PAINT_COUNTER_NAME
FIS_AUTH_PREFIX
INITIAL_SEND_TIME_DELAY_MS
INTERACTION_TO_NEXT_PAINT_ATTRIBUTE_NAME
INTERACTION_TO_NEXT_PAINT_METRIC_NAME
LARGEST_CONTENTFUL_PAINT_ATTRIBUTE_NAME
LARGEST_CONTENTFUL_PAINT_METRIC_NAME
MAX_ATTRIBUTE_NAME_LENGTH
MAX_ATTRIBUTE_VALUE_LENGTH
MAX_EVENT_COUNT_PER_REQUEST
MAX_METRIC_NAME_LENGTH
OOB_TRACE_PAGE_LOAD_PREFIX
REMOTE_CONFIG_SDK_VERSION
RESERVED_ATTRIBUTE_PREFIXES
RESERVED_AUTO_PREFIX
SDK_VERSION
SERVICE
SERVICE_NAME
TRACE_MEASURE_PREFIX
TRACE_START_MARK_PREFIX
TRACE_STOP_MARK_PREFIX
VisibilityState
apiInstance
consoleLogger
factory
firstInputDelay
iid
initializationPromise
initializationStatus
isTransportSetup
logger
name
oobMetrics
queue
remainingTries
sentPageLoadTrace
settingsServiceInstance
version
webVitalMetrics
windowInstance

+ CUMULATIVE_LAYOUT_SHIFT_ATTRIBUTE_NAME
+ CUMULATIVE_LAYOUT_SHIFT_METRIC_NAME
+ INTERACTION_TO_NEXT_PAINT_ATTRIBUTE_NAME
+ INTERACTION_TO_NEXT_PAINT_METRIC_NAME
+ LARGEST_CONTENTFUL_PAINT_ATTRIBUTE_NAME
+ LARGEST_CONTENTFUL_PAINT_METRIC_NAME
+ firstInputDelay
+ sentPageLoadTrace
+ webVitalMetrics
- FID_WAIT_TIME_MS

External Dependency

Module	Base (`32bf021`)	Merge (`1094997`)	Diff
`web-vitals/attribution`		onCLS onINP onLCP	+ onCLS + onINP + onLCP

`initializePerformance`

Size

Type	Base (`32bf021`)	Merge (`1094997`)	Diff
size	18.2 kB	19.0 kB	+867 B (+4.8%)
size-with-ext-deps	45.1 kB	55.5 kB	+10.4 kB (+23.2%)

Dependency

Type Base (32bf021) Merge (1094997) Diff

functions

50 dependencies

addToQueue
changeInitializationStatus
configValid
convertMetricValueToInteger
createNetworkRequestEntry
createUserTimingTrace
dispatchQueueEvents
getApiKey
getAppId
getApplicationInfo
getAuthTokenPromise
getConfig
getDocumentReadyComplete
getEffectiveConnectionType
getIid
getIidPromise
getInitializationPromise
getProjectId
getRemoteConfig
getServiceWorkerStatus
getStoredConfig
getVisibilityState
initializePerf
initializePerformance
isPerfInitialized
isValidCustomAttributeName
isValidCustomAttributeValue
isValidMetricName
logNetworkRequest
logTrace
mergeStrings
postToFlEndpoint
processConfig
processQueue
registerPerformance
sendEventsToFl
sendLog
sendTraceLog
serializeNetworkRequest
serializeTrace
serializer
setupApi
setupNetworkRequests
setupOobResources
setupOobTraces
setupTransportService
setupUserTimingTraces
shouldLogAfterSampling
storeConfig
transportHandler

52 dependencies

addToQueue
changeInitializationStatus
configValid
convertMetricValueToInteger
createNetworkRequestEntry
createUserTimingTrace
dispatchQueueEvents
flushLogs
flushQueuedEvents
getApiKey
getAppId
getApplicationInfo
getAuthTokenPromise
getConfig
getDocumentReadyComplete
getEffectiveConnectionType
getIid
getIidPromise
getInitializationPromise
getProjectId
getRemoteConfig
getServiceWorkerStatus
getStoredConfig
getVisibilityState
initializePerf
initializePerformance
isPerfInitialized
isValidCustomAttributeName
isValidCustomAttributeValue
isValidMetricName
logNetworkRequest
logTrace
mergeStrings
postToFlEndpoint
processConfig
processQueue
registerPerformance
sendLog
sendOobTrace
sendTraceLog
serializeNetworkRequest
serializeTrace
serializer
setupApi
setupNetworkRequests
setupOobResources
setupOobTraces
setupTransportService
setupUserTimingTraces
shouldLogAfterSampling
storeConfig
transportHandler

+ flushLogs
+ flushQueuedEvents
+ sendOobTrace
- sendEventsToFl

variables

46 dependencies

ATTRIBUTE_FORMAT_REGEX
CONFIG_EXPIRY_LOCAL_STORAGE_KEY
CONFIG_LOCAL_STORAGE_KEY
COULD_NOT_GET_CONFIG_MSG
DEFAULT_CONFIGS
DEFAULT_ENTRY_NAME
DEFAULT_REMAINING_TRIES
DEFAULT_SEND_INTERVAL_MS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
FID_WAIT_TIME_MS
FIRST_CONTENTFUL_PAINT_COUNTER_NAME
FIRST_INPUT_DELAY_COUNTER_NAME
FIRST_PAINT_COUNTER_NAME
FIS_AUTH_PREFIX
INITIAL_SEND_TIME_DELAY_MS
MAX_ATTRIBUTE_NAME_LENGTH
MAX_ATTRIBUTE_VALUE_LENGTH
MAX_EVENT_COUNT_PER_REQUEST
MAX_METRIC_NAME_LENGTH
OOB_TRACE_PAGE_LOAD_PREFIX
REMOTE_CONFIG_SDK_VERSION
RESERVED_ATTRIBUTE_PREFIXES
RESERVED_AUTO_PREFIX
SDK_VERSION
SERVICE
SERVICE_NAME
TRACE_MEASURE_PREFIX
TRACE_START_MARK_PREFIX
TRACE_STOP_MARK_PREFIX
VisibilityState
apiInstance
consoleLogger
factory
iid
initializationPromise
initializationStatus
isTransportSetup
logger
name
oobMetrics
queue
remainingTries
settingsServiceInstance
version
windowInstance

54 dependencies

ATTRIBUTE_FORMAT_REGEX
CONFIG_EXPIRY_LOCAL_STORAGE_KEY
CONFIG_LOCAL_STORAGE_KEY
COULD_NOT_GET_CONFIG_MSG
CUMULATIVE_LAYOUT_SHIFT_ATTRIBUTE_NAME
CUMULATIVE_LAYOUT_SHIFT_METRIC_NAME
DEFAULT_CONFIGS
DEFAULT_ENTRY_NAME
DEFAULT_REMAINING_TRIES
DEFAULT_SEND_INTERVAL_MS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
FIRST_CONTENTFUL_PAINT_COUNTER_NAME
FIRST_INPUT_DELAY_COUNTER_NAME
FIRST_PAINT_COUNTER_NAME
FIS_AUTH_PREFIX
INITIAL_SEND_TIME_DELAY_MS
INTERACTION_TO_NEXT_PAINT_ATTRIBUTE_NAME
INTERACTION_TO_NEXT_PAINT_METRIC_NAME
LARGEST_CONTENTFUL_PAINT_ATTRIBUTE_NAME
LARGEST_CONTENTFUL_PAINT_METRIC_NAME
MAX_ATTRIBUTE_NAME_LENGTH
MAX_ATTRIBUTE_VALUE_LENGTH
MAX_EVENT_COUNT_PER_REQUEST
MAX_METRIC_NAME_LENGTH
OOB_TRACE_PAGE_LOAD_PREFIX
REMOTE_CONFIG_SDK_VERSION
RESERVED_ATTRIBUTE_PREFIXES
RESERVED_AUTO_PREFIX
SDK_VERSION
SERVICE
SERVICE_NAME
TRACE_MEASURE_PREFIX
TRACE_START_MARK_PREFIX
TRACE_STOP_MARK_PREFIX
VisibilityState
apiInstance
consoleLogger
factory
firstInputDelay
iid
initializationPromise
initializationStatus
isTransportSetup
logger
name
oobMetrics
queue
remainingTries
sentPageLoadTrace
settingsServiceInstance
version
webVitalMetrics
windowInstance

+ CUMULATIVE_LAYOUT_SHIFT_ATTRIBUTE_NAME
+ CUMULATIVE_LAYOUT_SHIFT_METRIC_NAME
+ INTERACTION_TO_NEXT_PAINT_ATTRIBUTE_NAME
+ INTERACTION_TO_NEXT_PAINT_METRIC_NAME
+ LARGEST_CONTENTFUL_PAINT_ATTRIBUTE_NAME
+ LARGEST_CONTENTFUL_PAINT_METRIC_NAME
+ firstInputDelay
+ sentPageLoadTrace
+ webVitalMetrics
- FID_WAIT_TIME_MS

External Dependency

Module	Base (`32bf021`)	Merge (`1094997`)	Diff
`web-vitals/attribution`		onCLS onINP onLCP	+ onCLS + onINP + onLCP

`trace`

Size

Type	Base (`32bf021`)	Merge (`1094997`)	Diff
size	17.9 kB	18.8 kB	+877 B (+4.9%)
size-with-ext-deps	44.5 kB	54.9 kB	+10.4 kB (+23.5%)

Dependency

Type Base (32bf021) Merge (1094997) Diff

functions

50 dependencies

addToQueue
changeInitializationStatus
configValid
convertMetricValueToInteger
createNetworkRequestEntry
createUserTimingTrace
dispatchQueueEvents
getApiKey
getAppId
getApplicationInfo
getAuthTokenPromise
getConfig
getDocumentReadyComplete
getEffectiveConnectionType
getIid
getIidPromise
getInitializationPromise
getProjectId
getRemoteConfig
getServiceWorkerStatus
getStoredConfig
getVisibilityState
initializePerf
isPerfInitialized
isValidCustomAttributeName
isValidCustomAttributeValue
isValidMetricName
logNetworkRequest
logTrace
mergeStrings
postToFlEndpoint
processConfig
processQueue
registerPerformance
sendEventsToFl
sendLog
sendTraceLog
serializeNetworkRequest
serializeTrace
serializer
setupApi
setupNetworkRequests
setupOobResources
setupOobTraces
setupTransportService
setupUserTimingTraces
shouldLogAfterSampling
storeConfig
trace
transportHandler

52 dependencies

addToQueue
changeInitializationStatus
configValid
convertMetricValueToInteger
createNetworkRequestEntry
createUserTimingTrace
dispatchQueueEvents
flushLogs
flushQueuedEvents
getApiKey
getAppId
getApplicationInfo
getAuthTokenPromise
getConfig
getDocumentReadyComplete
getEffectiveConnectionType
getIid
getIidPromise
getInitializationPromise
getProjectId
getRemoteConfig
getServiceWorkerStatus
getStoredConfig
getVisibilityState
initializePerf
isPerfInitialized
isValidCustomAttributeName
isValidCustomAttributeValue
isValidMetricName
logNetworkRequest
logTrace
mergeStrings
postToFlEndpoint
processConfig
processQueue
registerPerformance
sendLog
sendOobTrace
sendTraceLog
serializeNetworkRequest
serializeTrace
serializer
setupApi
setupNetworkRequests
setupOobResources
setupOobTraces
setupTransportService
setupUserTimingTraces
shouldLogAfterSampling
storeConfig
trace
transportHandler

+ flushLogs
+ flushQueuedEvents
+ sendOobTrace
- sendEventsToFl

variables

46 dependencies

ATTRIBUTE_FORMAT_REGEX
CONFIG_EXPIRY_LOCAL_STORAGE_KEY
CONFIG_LOCAL_STORAGE_KEY
COULD_NOT_GET_CONFIG_MSG
DEFAULT_CONFIGS
DEFAULT_ENTRY_NAME
DEFAULT_REMAINING_TRIES
DEFAULT_SEND_INTERVAL_MS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
FID_WAIT_TIME_MS
FIRST_CONTENTFUL_PAINT_COUNTER_NAME
FIRST_INPUT_DELAY_COUNTER_NAME
FIRST_PAINT_COUNTER_NAME
FIS_AUTH_PREFIX
INITIAL_SEND_TIME_DELAY_MS
MAX_ATTRIBUTE_NAME_LENGTH
MAX_ATTRIBUTE_VALUE_LENGTH
MAX_EVENT_COUNT_PER_REQUEST
MAX_METRIC_NAME_LENGTH
OOB_TRACE_PAGE_LOAD_PREFIX
REMOTE_CONFIG_SDK_VERSION
RESERVED_ATTRIBUTE_PREFIXES
RESERVED_AUTO_PREFIX
SDK_VERSION
SERVICE
SERVICE_NAME
TRACE_MEASURE_PREFIX
TRACE_START_MARK_PREFIX
TRACE_STOP_MARK_PREFIX
VisibilityState
apiInstance
consoleLogger
factory
iid
initializationPromise
initializationStatus
isTransportSetup
logger
name
oobMetrics
queue
remainingTries
settingsServiceInstance
version
windowInstance

54 dependencies

ATTRIBUTE_FORMAT_REGEX
CONFIG_EXPIRY_LOCAL_STORAGE_KEY
CONFIG_LOCAL_STORAGE_KEY
COULD_NOT_GET_CONFIG_MSG
CUMULATIVE_LAYOUT_SHIFT_ATTRIBUTE_NAME
CUMULATIVE_LAYOUT_SHIFT_METRIC_NAME
DEFAULT_CONFIGS
DEFAULT_ENTRY_NAME
DEFAULT_REMAINING_TRIES
DEFAULT_SEND_INTERVAL_MS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
FIRST_CONTENTFUL_PAINT_COUNTER_NAME
FIRST_INPUT_DELAY_COUNTER_NAME
FIRST_PAINT_COUNTER_NAME
FIS_AUTH_PREFIX
INITIAL_SEND_TIME_DELAY_MS
INTERACTION_TO_NEXT_PAINT_ATTRIBUTE_NAME
INTERACTION_TO_NEXT_PAINT_METRIC_NAME
LARGEST_CONTENTFUL_PAINT_ATTRIBUTE_NAME
LARGEST_CONTENTFUL_PAINT_METRIC_NAME
MAX_ATTRIBUTE_NAME_LENGTH
MAX_ATTRIBUTE_VALUE_LENGTH
MAX_EVENT_COUNT_PER_REQUEST
MAX_METRIC_NAME_LENGTH
OOB_TRACE_PAGE_LOAD_PREFIX
REMOTE_CONFIG_SDK_VERSION
RESERVED_ATTRIBUTE_PREFIXES
RESERVED_AUTO_PREFIX
SDK_VERSION
SERVICE
SERVICE_NAME
TRACE_MEASURE_PREFIX
TRACE_START_MARK_PREFIX
TRACE_STOP_MARK_PREFIX
VisibilityState
apiInstance
consoleLogger
factory
firstInputDelay
iid
initializationPromise
initializationStatus
isTransportSetup
logger
name
oobMetrics
queue
remainingTries
sentPageLoadTrace
settingsServiceInstance
version
webVitalMetrics
windowInstance

+ CUMULATIVE_LAYOUT_SHIFT_ATTRIBUTE_NAME
+ CUMULATIVE_LAYOUT_SHIFT_METRIC_NAME
+ INTERACTION_TO_NEXT_PAINT_ATTRIBUTE_NAME
+ INTERACTION_TO_NEXT_PAINT_METRIC_NAME
+ LARGEST_CONTENTFUL_PAINT_ATTRIBUTE_NAME
+ LARGEST_CONTENTFUL_PAINT_METRIC_NAME
+ firstInputDelay
+ sentPageLoadTrace
+ webVitalMetrics
- FID_WAIT_TIME_MS

External Dependency

Module	Base (`32bf021`)	Merge (`1094997`)	Diff
`web-vitals/attribution`		onCLS onINP onLCP	+ onCLS + onINP + onLCP

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/rszHeAoyqK.html

packages/performance/src/resources/trace.ts

packages/performance/src/services/oob_resources_service.ts

packages/performance/src/services/transport_service.ts

raymondlam · 2024-11-27T21:49:46Z

packages/performance/src/services/oob_resources_service.test.ts

  let getEntriesByTypeStub: SinonStub<[EntryType], PerformanceEntry[]>;
  let setupObserverStub: SinonStub<
    [EntryType, (entry: PerformanceEntry) => void],
    void
  >;
-  let createOobTraceStub: SinonStub<
+  let createOobTraceStub: SinonSpy<


nit: createOobTraceStub -> createOobTraceSpy

raymondlam · 2024-11-27T22:08:15Z

packages/performance/src/services/transport_service.ts

-    method: 'POST',
-    body: JSON.stringify(data)
-  });
+  return navigator.sendBeacon(flTransportFullUrl, JSON.stringify(data));


We should have a fall back to fetch if sendBeacon fails (eg. payload is > then the ~64KB limit)

(navigator.sendBeacon && navigator.sendBeacon(flTransportFullUrl, JSON.stringify(data))) || fetch(flTransportFullUrl, { method: 'POST', body: JSON.stringify(data), keepalive: true } );

…for Web. Modifies export to use sendBeacon instead of fetch API, and shifts the upload time to the first time the page is hidden or unloaded.

…load now, so no need to add additional timeouts.

… often updates the values at unload time, and os queuing this until the end means those latest values get captured.

github-actions · 2025-01-06T20:27:14Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

bryanatkinson requested a review from raymondlam November 18, 2024 22:18

bryanatkinson requested review from jposuna and a team as code owners November 18, 2024 22:18

raymondlam approved these changes Nov 21, 2024

View reviewed changes

packages/performance/src/resources/trace.ts Show resolved Hide resolved

packages/performance/src/services/oob_resources_service.ts Outdated Show resolved Hide resolved

packages/performance/src/services/transport_service.ts Show resolved Hide resolved

bryanatkinson force-pushed the fireperf-web-vitals branch from fe72ce1 to 4b4d9ad Compare November 26, 2024 19:54

bryanatkinson requested a review from hsubox76 November 26, 2024 19:54

raymondlam approved these changes Nov 27, 2024

View reviewed changes

bryanatkinson added 12 commits January 6, 2025 15:19

Add support for capturing web vitals metrics in Firebase performance …

f09450c

…for Web. Modifies export to use sendBeacon instead of fetch API, and shifts the upload time to the first time the page is hidden or unloaded.

Add unit tests for oob_resource_service changes to include web vitals.

98349e4

Update perf_logger tests.

797630d

Remove .only in test.

cf21c1a

Update transport_service test.

b561409

Remove flush from tests due to globals conflict.

9e069b8

Run format

e5d8010

Remove FID wait timeout on OOB trace send. This gets sent at first un…

e3ede56

…load now, so no need to add additional timeouts.

Queue OOB trace instead of sending right away. The web vitals library…

5d1b7af

… often updates the values at unload time, and os queuing this until the end means those latest values get captured.

Update tests

b399ad1

Update tests

8247b6a

Run format

721fcbf

bryanatkinson force-pushed the fireperf-web-vitals branch from 8ca7c35 to 721fcbf Compare January 6, 2025 20:20

Add changeset

c9d3392

bryanatkinson requested review from a team as code owners January 6, 2025 20:25

Update changeset to include firebase

22a8ae5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fireperf web vitals #8644

Fireperf web vitals #8644

bryanatkinson commented Nov 18, 2024

changeset-bot bot commented Nov 18, 2024 •

edited

Loading

google-oss-bot commented Nov 18, 2024 •

edited

Loading

`@firebase/performance`

`bundle`

`firebase`

google-oss-bot commented Nov 18, 2024 •

edited

Loading

`@firebase/performance`

`getPerformance`

`initializePerformance`

`trace`

raymondlam Nov 27, 2024

bryanatkinson Dec 19, 2024

raymondlam Nov 27, 2024

bryanatkinson Dec 19, 2024

github-actions bot commented Jan 6, 2025 •

edited

Loading

Fireperf web vitals #8644

Are you sure you want to change the base?

Fireperf web vitals #8644

Conversation

bryanatkinson commented Nov 18, 2024

changeset-bot bot commented Nov 18, 2024 • edited Loading

🦋 Changeset detected

google-oss-bot commented Nov 18, 2024 • edited Loading

Size Report 1

Affected Products

@firebase/performance

bundle

firebase

Test Logs

google-oss-bot commented Nov 18, 2024 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/performance

getPerformance

initializePerformance

trace

Test Logs

raymondlam Nov 27, 2024

Choose a reason for hiding this comment

bryanatkinson Dec 19, 2024

Choose a reason for hiding this comment

raymondlam Nov 27, 2024

Choose a reason for hiding this comment

bryanatkinson Dec 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025 • edited Loading

Changeset File Check ✅

changeset-bot bot commented Nov 18, 2024 •

edited

Loading

google-oss-bot commented Nov 18, 2024 •

edited

Loading

Size Report ¹

`@firebase/performance`

`bundle`

`firebase`

google-oss-bot commented Nov 18, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/performance`

`getPerformance`

`initializePerformance`

`trace`

github-actions bot commented Jan 6, 2025 •

edited

Loading