Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] WebOTP #7757

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] WebOTP #7757

wants to merge 2 commits into from

Conversation

renkelvin
Copy link

No description provided.

Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: e1a2133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

google-cla bot commented Nov 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 7, 2023

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (5c7fa84)Merge (37d0f03)Diff
    browser177 kB179 kB+2.33 kB (+1.3%)
    cordova205 kB205 kB+108 B (+0.1%)
    esm5230 kB233 kB+3.07 kB (+1.3%)
    main175 kB175 kB+108 B (+0.1%)
    module177 kB179 kB+2.33 kB (+1.3%)
    react-native194 kB197 kB+3.12 kB (+1.6%)
  • @firebase/auth/cordova

    TypeBase (5c7fa84)Merge (37d0f03)Diff
    browser205 kB205 kB+108 B (+0.1%)
    module205 kB205 kB+108 B (+0.1%)
  • @firebase/auth/internal

    TypeBase (5c7fa84)Merge (37d0f03)Diff
    browser187 kB190 kB+2.33 kB (+1.2%)
    esm5244 kB247 kB+3.07 kB (+1.3%)
    main211 kB211 kB+108 B (+0.1%)
    module187 kB190 kB+2.33 kB (+1.2%)
  • bundle

    TypeBase (5c7fa84)Merge (37d0f03)Diff
    auth (Phone)83.8 kB85.2 kB+1.48 kB (+1.8%)
  • firebase

    TypeBase (5c7fa84)Merge (37d0f03)Diff
    firebase-auth-compat.js136 kB138 kB+1.49 kB (+1.1%)
    firebase-auth-cordova.js174 kB174 kB+107 B (+0.1%)
    firebase-auth.js147 kB148 kB+1.72 kB (+1.2%)
    firebase-compat.js778 kB780 kB+1.50 kB (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xzW2EbuOl1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 7, 2023

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • AuthErrorCodes

      Size

      TypeBase (5c7fa84)Merge (37d0f03)Diff
      size42.4 kB42.5 kB+51 B (+0.1%)
      size-with-ext-deps63.3 kB63.4 kB+51 B (+0.1%)
    • PhoneAuthProvider

      Size

      TypeBase (5c7fa84)Merge (37d0f03)Diff
      size41.2 kB41.2 kB+60 B (+0.1%)
      size-with-ext-deps62.1 kB62.1 kB+60 B (+0.1%)
    • debugErrorMap

      Size

      TypeBase (5c7fa84)Merge (37d0f03)Diff
      size49.6 kB49.6 kB+55 B (+0.1%)
      size-with-ext-deps70.4 kB70.5 kB+55 B (+0.1%)
    • linkWithPhoneNumber

      Size

      TypeBase (5c7fa84)Merge (37d0f03)Diff
      size41.9 kB43.4 kB+1.47 kB (+3.5%)
      size-with-ext-deps62.8 kB64.3 kB+1.48 kB (+2.3%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (5c7fa84)Merge (37d0f03)Diff
      size42.5 kB43.9 kB+1.47 kB (+3.5%)
      size-with-ext-deps63.4 kB64.9 kB+1.48 kB (+2.3%)
    • signInWithPhoneNumber

      Size

      TypeBase (5c7fa84)Merge (37d0f03)Diff
      size42.3 kB43.7 kB+1.47 kB (+3.5%)
      size-with-ext-deps63.2 kB64.6 kB+1.48 kB (+2.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pIwtVXHTej.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants