-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix composite index testing build bug #7682
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
.gitignore
Outdated
*.tfstate.* | ||
*/project.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for new jsons generated by terraform? The one in config/ is already gitignored in line 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a guideline for local configuring, and instructed to add "project.json" file of their target firebase project inside Firestore, where the terraform is. It makes more sense to keep everything needed in one place, instead of updating the "project.json" in config instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a second thought, maybe there is no big difference.
/integration/util/composite_index_test_helper.ts
ingulpfile.js
.src
folder dependency incomposite_index_test_helper.ts
file.ReadMe
file.