Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composite index testing build bug #7682

Merged
merged 12 commits into from
Oct 13, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Oct 5, 2023

  • Fix the build reference problem caused by not including /integration/util/composite_index_test_helper.ts in gulpfile.js.
  • Internally export AutoId for integration testing, and remove the src folder dependency in composite_index_test_helper.ts file.
  • Add a detailed composite index testing development instruction in the ReadMe file.

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: d39bf95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2023

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (cbfd14c)Merge (404a09b)Diff
    browser374 kB374 kB+78 B (+0.0%)
    esm5359 kB359 kB+64 B (+0.0%)
    main575 kB575 kB+44 B (+0.0%)
    module374 kB374 kB+78 B (+0.0%)
    react-native374 kB374 kB+78 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (cbfd14c)Merge (404a09b)Diff
    browser109 kB109 kB+47 B (+0.0%)
    esm5106 kB106 kB+47 B (+0.0%)
    main150 kB150 kB-6 B (-0.0%)
    module109 kB109 kB+47 B (+0.0%)
    react-native109 kB109 kB+47 B (+0.0%)
  • bundle

    12 size changes

    TypeBase (cbfd14c)Merge (404a09b)Diff
    firestore (Persistence)302 kB302 kB+6 B (+0.0%)
    firestore (Query Cursors)238 kB238 kB+12 B (+0.0%)
    firestore (Query)236 kB236 kB+8 B (+0.0%)
    firestore (Read data once)224 kB224 kB+12 B (+0.0%)
    firestore (Realtime updates)226 kB226 kB+12 B (+0.0%)
    firestore (Transaction)204 kB204 kB+12 B (+0.0%)
    firestore (Write data)203 kB203 kB+12 B (+0.0%)
    firestore-lite (Query Cursors)88.8 kB88.8 kB+5 B (+0.0%)
    firestore-lite (Query)85.0 kB85.0 kB-3 B (-0.0%)
    firestore-lite (Read data once)61.3 kB61.3 kB+8 B (+0.0%)
    firestore-lite (Transaction)86.2 kB86.2 kB+5 B (+0.0%)
    firestore-lite (Write data)70.9 kB70.9 kB+5 B (+0.0%)

  • firebase

    TypeBase (cbfd14c)Merge (404a09b)Diff
    firebase-compat.js778 kB778 kB+10 B (+0.0%)
    firebase-firestore-compat.js340 kB340 kB+10 B (+0.0%)
    firebase-firestore-lite.js116 kB116 kB+47 B (+0.0%)
    firebase-firestore.js434 kB434 kB+78 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4mxg6VEu9N.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2023

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • AbstractUserDataWriter

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size25.8 kB25.8 kB+8 B (+0.0%)
      size-with-ext-deps95.4 kB95.5 kB+8 B (+0.0%)
    • AggregateField

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+7 B (+0.0%)
      size-with-ext-deps87.4 kB87.5 kB+7 B (+0.0%)
    • AggregateQuerySnapshot

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.9 kB17.9 kB+8 B (+0.0%)
      size-with-ext-deps87.5 kB87.5 kB+8 B (+0.0%)
    • Bytes

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size19.3 kB19.3 kB+8 B (+0.0%)
      size-with-ext-deps88.9 kB88.9 kB+8 B (+0.0%)
    • CACHE_SIZE_UNLIMITED

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.7 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • CollectionReference

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size21.3 kB21.3 kB+8 B (+0.0%)
      size-with-ext-deps91.0 kB91.0 kB+8 B (+0.0%)
    • DocumentReference

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size21.3 kB21.3 kB+8 B (+0.0%)
      size-with-ext-deps91.0 kB91.0 kB+8 B (+0.0%)
    • DocumentSnapshot

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size24.8 kB24.8 kB+8 B (+0.0%)
      size-with-ext-deps94.5 kB94.5 kB+8 B (+0.0%)
    • FieldPath

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size20.4 kB20.4 kB+8 B (+0.0%)
      size-with-ext-deps90.0 kB90.1 kB+8 B (+0.0%)
    • FieldValue

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • Firestore

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.7 kB17.7 kB+8 B (+0.0%)
      size-with-ext-deps87.3 kB87.3 kB+8 B (+0.0%)
    • FirestoreError

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.7 kB17.7 kB+8 B (+0.0%)
      size-with-ext-deps87.3 kB87.3 kB+8 B (+0.0%)
    • GeoPoint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.3 kB18.3 kB+8 B (+0.0%)
      size-with-ext-deps87.9 kB87.9 kB+8 B (+0.0%)
    • LoadBundleTask

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.6 kB18.6 kB+8 B (+0.0%)
      size-with-ext-deps88.2 kB88.2 kB+8 B (+0.0%)
    • PersistentCacheIndexManager

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • Query

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.9 kB17.9 kB+8 B (+0.0%)
      size-with-ext-deps87.5 kB87.5 kB+8 B (+0.0%)
    • QueryCompositeFilterConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size20.0 kB20.0 kB+8 B (+0.0%)
      size-with-ext-deps89.6 kB89.6 kB+8 B (+0.0%)
    • QueryConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • QueryDocumentSnapshot

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size24.8 kB24.8 kB+8 B (+0.0%)
      size-with-ext-deps94.5 kB94.5 kB+8 B (+0.0%)
    • QueryEndAtConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size43.3 kB43.4 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • QueryFieldFilterConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size41.3 kB41.3 kB+8 B (+0.0%)
      size-with-ext-deps111 kB111 kB+8 B (+0.0%)
    • QueryLimitConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.5 kB18.5 kB+8 B (+0.0%)
      size-with-ext-deps88.1 kB88.2 kB+8 B (+0.0%)
    • QueryOrderByConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.9 kB18.9 kB+8 B (+0.0%)
      size-with-ext-deps88.6 kB88.6 kB+8 B (+0.0%)
    • QuerySnapshot

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size26.7 kB26.8 kB+8 B (+0.0%)
      size-with-ext-deps96.4 kB96.4 kB+8 B (+0.0%)
    • QueryStartAtConstraint

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size43.3 kB43.4 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • SnapshotMetadata

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.9 kB17.9 kB+8 B (+0.0%)
      size-with-ext-deps87.5 kB87.5 kB+8 B (+0.0%)
    • Timestamp

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.9 kB18.9 kB+8 B (+0.0%)
      size-with-ext-deps88.5 kB88.5 kB+8 B (+0.0%)
    • Transaction

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size51.5 kB51.5 kB+8 B (+0.0%)
      size-with-ext-deps121 kB121 kB+8 B (+0.0%)
    • WriteBatch

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size48.3 kB48.3 kB+8 B (+0.0%)
      size-with-ext-deps118 kB118 kB+8 B (+0.0%)
    • _AutoId

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size?17.7 kB? (?)
      size-with-ext-deps?87.3 kB? (?)

      Dependency

      TypeBase (cbfd14c)Merge (404a09b)Diff
      functions?

      12 dependencies

      __PRIVATE_argToString
      __PRIVATE_cloneLongPollingOptions
      __PRIVATE_configureFirestore
      __PRIVATE_hardAssert
      __PRIVATE_isIndexedDbTransactionError
      __PRIVATE_logDebug
      __PRIVATE_logError
      __PRIVATE_randomBytes
      __PRIVATE_validateIsNotUsedTogether
      __PRIVATE_wrapInUserErrorIfRecoverable
      fail
      getDocument

      ?
      classes?

      20 dependencies

      AppCheckToken
      DatabaseId
      DatabaseInfo
      DelayedOperation
      Firestore
      Firestore$1
      FirestoreClient
      FirestoreError
      FirestoreSettingsImpl
      User
      __PRIVATE_AsyncQueueImpl
      __PRIVATE_AutoId
      __PRIVATE_Deferred
      __PRIVATE_EmptyAuthCredentialsProvider
      __PRIVATE_ExponentialBackoff
      __PRIVATE_FirebaseAppCheckTokenProvider
      __PRIVATE_FirebaseAuthCredentialsProvider
      __PRIVATE_FirstPartyAuthCredentialsProvider
      __PRIVATE_FirstPartyToken
      __PRIVATE_OAuthToken

      ?
      variables?

      D
      S
      ae
      b
      me
      ue
      w

      ?
      enums??

      External Dependency

      ModuleBase (cbfd14c)Merge (404a09b)Diff
      @firebase/app?

      SDK_VERSION
      _registerComponent
      registerVersion

      ?
      @firebase/component?

      Component

      ?
      @firebase/logger?

      LogLevel
      Logger

      ?
      @firebase/util?

      FirebaseError

      ?
      @firebase/webchannel-wrapper?

      Integer

      ?
    • _ByteString

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.8 kB18.8 kB+8 B (+0.0%)
      size-with-ext-deps88.4 kB88.4 kB+8 B (+0.0%)
    • _DatabaseId

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.7 kB17.7 kB+8 B (+0.0%)
      size-with-ext-deps87.3 kB87.3 kB+8 B (+0.0%)
    • _DocumentKey

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size27.0 kB27.0 kB+8 B (+0.0%)
      size-with-ext-deps96.7 kB96.7 kB+8 B (+0.0%)
    • _EmptyAppCheckTokenProvider

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.5 kB+8 B (+0.0%)
    • _EmptyAuthCredentialsProvider

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.7 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • _FieldPath

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size20.1 kB20.2 kB+8 B (+0.0%)
      size-with-ext-deps89.8 kB89.8 kB+8 B (+0.0%)
    • _TestingHooks

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.2 kB18.2 kB+8 B (+0.0%)
      size-with-ext-deps87.8 kB87.8 kB+8 B (+0.0%)
    • _cast

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.5 kB18.5 kB+8 B (+0.0%)
      size-with-ext-deps88.1 kB88.1 kB+8 B (+0.0%)
    • _debugAssert

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • _isBase64Available

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • _logWarn

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • _validateIsNotUsedTogether

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.7 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.3 kB87.4 kB+8 B (+0.0%)
    • addDoc

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size123 kB123 kB+12 B (+0.0%)
      size-with-ext-deps193 kB193 kB+12 B (+0.0%)
    • aggregateFieldEqual

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.1 kB18.1 kB+5 B (+0.0%)
      size-with-ext-deps87.7 kB87.7 kB+5 B (+0.0%)
    • aggregateQuerySnapshotEqual

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size40.6 kB40.6 kB+8 B (+0.0%)
      size-with-ext-deps111 kB111 kB+8 B (+0.0%)
    • and

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size42.6 kB42.6 kB+8 B (+0.0%)
      size-with-ext-deps112 kB112 kB+8 B (+0.0%)
    • arrayRemove

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size30.5 kB30.5 kB+8 B (+0.0%)
      size-with-ext-deps100 kB100 kB+8 B (+0.0%)
    • arrayUnion

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size30.5 kB30.5 kB+8 B (+0.0%)
      size-with-ext-deps100 kB100 kB+8 B (+0.0%)
    • average

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size21.4 kB21.4 kB+7 B (+0.0%)
      size-with-ext-deps91.1 kB91.1 kB+7 B (+0.0%)
    • clearIndexedDbPersistence

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size26.5 kB26.5 kB+8 B (+0.0%)
      size-with-ext-deps96.3 kB96.3 kB+8 B (+0.0%)
    • collection

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size22.1 kB22.1 kB+8 B (+0.0%)
      size-with-ext-deps91.7 kB91.8 kB+8 B (+0.0%)
    • collectionGroup

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size21.1 kB21.1 kB+8 B (+0.0%)
      size-with-ext-deps90.7 kB90.7 kB+8 B (+0.0%)
    • connectFirestoreEmulator

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size19.6 kB19.6 kB+8 B (+0.0%)
      size-with-ext-deps89.7 kB89.8 kB+8 B (+0.0%)
    • count

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.9 kB17.9 kB+7 B (+0.0%)
      size-with-ext-deps87.5 kB87.5 kB+7 B (+0.0%)
    • deleteAllPersistentCacheIndexes

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size87.1 kB87.1 kB+8 B (+0.0%)
      size-with-ext-deps157 kB157 kB+8 B (+0.0%)
    • deleteDoc

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size114 kB114 kB+8 B (+0.0%)
      size-with-ext-deps184 kB184 kB+8 B (+0.0%)
    • deleteField

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.1 kB18.1 kB+8 B (+0.0%)
      size-with-ext-deps87.7 kB87.7 kB+8 B (+0.0%)
    • disableNetwork

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size102 kB102 kB+8 B (+0.0%)
      size-with-ext-deps173 kB173 kB+8 B (+0.0%)
    • disablePersistentCacheIndexAutoCreation

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size87.1 kB87.1 kB+8 B (+0.0%)
      size-with-ext-deps157 kB157 kB+8 B (+0.0%)
    • doc

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size22.1 kB22.1 kB+12 B (+0.1%)
      size-with-ext-deps91.8 kB91.8 kB+12 B (+0.0%)
    • documentId

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size20.5 kB20.5 kB+8 B (+0.0%)
      size-with-ext-deps90.1 kB90.1 kB+8 B (+0.0%)
    • enableIndexedDbPersistence

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size186 kB186 kB+6 B (+0.0%)
      size-with-ext-deps257 kB257 kB+6 B (+0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size221 kB221 kB+6 B (+0.0%)
      size-with-ext-deps293 kB293 kB+6 B (+0.0%)
    • enableNetwork

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size102 kB102 kB+8 B (+0.0%)
      size-with-ext-deps173 kB173 kB+8 B (+0.0%)
    • enablePersistentCacheIndexAutoCreation

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size87.1 kB87.1 kB+8 B (+0.0%)
      size-with-ext-deps157 kB157 kB+8 B (+0.0%)
    • endAt

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size43.4 kB43.4 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • endBefore

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size43.4 kB43.4 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • ensureFirestoreConfigured

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.9 kB+8 B (+0.0%)
      size-with-ext-deps87.5 kB87.5 kB+8 B (+0.0%)
    • executeWrite

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size113 kB113 kB+8 B (+0.0%)
      size-with-ext-deps183 kB183 kB+8 B (+0.0%)
    • getAggregateFromServer

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size109 kB109 kB+51 B (+0.0%)
      size-with-ext-deps180 kB180 kB+51 B (+0.0%)
    • getCountFromServer

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size110 kB110 kB+50 B (+0.0%)
      size-with-ext-deps180 kB180 kB+50 B (+0.0%)
    • getDoc

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size143 kB143 kB+8 B (+0.0%)
      size-with-ext-deps213 kB213 kB+8 B (+0.0%)
    • getDocFromCache

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size94.6 kB94.6 kB+8 B (+0.0%)
      size-with-ext-deps164 kB164 kB+8 B (+0.0%)
    • getDocFromServer

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size143 kB143 kB+8 B (+0.0%)
      size-with-ext-deps213 kB213 kB+8 B (+0.0%)
    • getDocs

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size145 kB145 kB+8 B (+0.0%)
      size-with-ext-deps215 kB215 kB+8 B (+0.0%)
    • getDocsFromCache

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size102 kB102 kB+8 B (+0.0%)
      size-with-ext-deps172 kB172 kB+8 B (+0.0%)
    • getDocsFromServer

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size144 kB144 kB+8 B (+0.0%)
      size-with-ext-deps215 kB215 kB+8 B (+0.0%)
    • getFirestore

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size19.8 kB19.8 kB+8 B (+0.0%)
      size-with-ext-deps97.6 kB97.6 kB+8 B (+0.0%)
    • getPersistentCacheIndexManager

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size19.0 kB19.0 kB+8 B (+0.0%)
      size-with-ext-deps88.6 kB88.6 kB+8 B (+0.0%)
    • increment

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.6 kB18.6 kB+8 B (+0.0%)
      size-with-ext-deps88.2 kB88.2 kB+8 B (+0.0%)
    • initializeFirestore

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.7 kB18.7 kB+8 B (+0.0%)
      size-with-ext-deps88.7 kB88.7 kB+8 B (+0.0%)
    • limit

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.7 kB18.7 kB+8 B (+0.0%)
      size-with-ext-deps88.3 kB88.3 kB+8 B (+0.0%)
    • limitToLast

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.7 kB18.7 kB+8 B (+0.0%)
      size-with-ext-deps88.3 kB88.3 kB+8 B (+0.0%)
    • loadBundle

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size112 kB112 kB+8 B (+0.0%)
      size-with-ext-deps182 kB182 kB+8 B (+0.0%)
    • memoryEagerGarbageCollector

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size85.1 kB85.1 kB+8 B (+0.0%)
      size-with-ext-deps155 kB155 kB+8 B (+0.0%)
    • memoryLocalCache

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size99.4 kB99.4 kB+8 B (+0.0%)
      size-with-ext-deps170 kB170 kB+8 B (+0.0%)
    • memoryLruGarbageCollector

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size91.6 kB91.6 kB+8 B (+0.0%)
      size-with-ext-deps162 kB162 kB+8 B (+0.0%)
    • namedQuery

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size88.0 kB88.0 kB+8 B (+0.0%)
      size-with-ext-deps158 kB158 kB+8 B (+0.0%)
    • onSnapshot

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size145 kB145 kB+8 B (+0.0%)
      size-with-ext-deps216 kB216 kB+8 B (+0.0%)
    • onSnapshotsInSync

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size135 kB135 kB+8 B (+0.0%)
      size-with-ext-deps205 kB205 kB+8 B (+0.0%)
    • or

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size42.6 kB42.6 kB+8 B (+0.0%)
      size-with-ext-deps112 kB112 kB+8 B (+0.0%)
    • orderBy

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size22.4 kB22.5 kB+8 B (+0.0%)
      size-with-ext-deps92.1 kB92.1 kB+8 B (+0.0%)
    • persistentLocalCache

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size183 kB183 kB+6 B (+0.0%)
      size-with-ext-deps255 kB255 kB+6 B (+0.0%)
    • persistentMultipleTabManager

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size218 kB218 kB+6 B (+0.0%)
      size-with-ext-deps290 kB290 kB+6 B (+0.0%)
    • persistentSingleTabManager

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size182 kB182 kB+6 B (+0.0%)
      size-with-ext-deps254 kB254 kB+6 B (+0.0%)
    • query

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size42.9 kB42.9 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • queryEqual

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size40.5 kB40.5 kB+8 B (+0.0%)
      size-with-ext-deps110 kB110 kB+8 B (+0.0%)
    • refEqual

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size21.5 kB21.5 kB+8 B (+0.0%)
      size-with-ext-deps91.2 kB91.2 kB+8 B (+0.0%)
    • runTransaction

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size123 kB123 kB+8 B (+0.0%)
      size-with-ext-deps193 kB193 kB+8 B (+0.0%)
    • serverTimestamp

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size18.0 kB18.0 kB+8 B (+0.0%)
      size-with-ext-deps87.6 kB87.7 kB+8 B (+0.0%)
    • setDoc

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size122 kB122 kB+8 B (+0.0%)
      size-with-ext-deps193 kB193 kB+8 B (+0.0%)
    • setIndexConfiguration

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size90.6 kB90.7 kB+8 B (+0.0%)
      size-with-ext-deps161 kB161 kB+8 B (+0.0%)
    • setLogLevel

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.4 kB87.4 kB+8 B (+0.0%)
    • snapshotEqual

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size46.2 kB46.2 kB+8 B (+0.0%)
      size-with-ext-deps116 kB116 kB+8 B (+0.0%)
    • startAfter

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size43.4 kB43.4 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • startAt

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size43.4 kB43.4 kB+8 B (+0.0%)
      size-with-ext-deps113 kB113 kB+8 B (+0.0%)
    • sum

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size21.4 kB21.4 kB+7 B (+0.0%)
      size-with-ext-deps91.1 kB91.1 kB+7 B (+0.0%)
    • terminate

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size17.8 kB17.8 kB+8 B (+0.0%)
      size-with-ext-deps87.6 kB87.6 kB+8 B (+0.0%)
    • updateDoc

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size123 kB123 kB+8 B (+0.0%)
      size-with-ext-deps193 kB193 kB+8 B (+0.0%)
    • waitForPendingWrites

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size103 kB103 kB+8 B (+0.0%)
      size-with-ext-deps173 kB173 kB+8 B (+0.0%)
    • where

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size42.1 kB42.1 kB+8 B (+0.0%)
      size-with-ext-deps112 kB112 kB+8 B (+0.0%)
    • writeBatch

      Size

      TypeBase (cbfd14c)Merge (404a09b)Diff
      size125 kB125 kB+8 B (+0.0%)
      size-with-ext-deps195 kB195 kB+8 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cEIUJHkufP.html

@milaGGL milaGGL marked this pull request as ready for review October 6, 2023 14:09
@milaGGL milaGGL requested review from a team as code owners October 6, 2023 14:09
@milaGGL milaGGL changed the title Mila/fix composite index testing import bug Fix composite index testing build bug Oct 6, 2023
@milaGGL milaGGL requested a review from ehsannas October 10, 2023 14:16
@milaGGL milaGGL self-assigned this Oct 10, 2023
.gitignore Outdated
*.tfstate.*
*/project.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for new jsons generated by terraform? The one in config/ is already gitignored in line 6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a guideline for local configuring, and instructed to add "project.json" file of their target firebase project inside Firestore, where the terraform is. It makes more sense to keep everything needed in one place, instead of updating the "project.json" in config instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a second thought, maybe there is no big difference.

@milaGGL milaGGL merged commit 8283a55 into master Oct 13, 2023
41 checks passed
@milaGGL milaGGL deleted the mila/fix-composite-index-testing-import-bug branch October 13, 2023 14:12
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants