Fix FetchProvider in non-browser environment #7634
Conversation
ocavue
requested review from
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
🦋 Changeset detectedLatest commit: 9dda1e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks good to me.. @hsubox76 FYI |
|
Can you add a changeset? Run |
|
@hsubox76 Changeset file has been added |
|
Any update on merging this? |
|
Requesting review from @hsubox76 or @DellaBitta , thanks! |
There was a problem hiding this comment.
I don't want to hold this PR up but in the future we should think about putting any changes we need to make global variable checking more robust in this function in firebase/util and using it in all places that need globalThis: https://github.com/firebase/firebase-js-sdk/blob/master/packages/util/src/global.ts#L23 I think it's only used in two places right now but we should check if there's any other instances of self that would benefit from it.
|
Sorry, this is my fault for the delay, but it looks like triggering a re-run of the failed jobs doesn't work because the build artifact it's trying to use has expired. Can you push an empty commit to trigger a new CI run? |
|
I pushed a new empty commit. The workflow requires approval to run. |
|
Sorry, I made the same mistake 🙏 |
Discussion
This PR tries get the fetch implementation from not only
selfbut also standardglobalThis. This would allow Firebase to get the fetch implementation in non-browser JavaScript environment, like Vercel Edge Runtime.Closes #7633
Closes #7533
Testing
N/A
API Changes
No API changes