Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Streamable functions #14395

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

[WIP] Streamable functions #14395

wants to merge 55 commits into from

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 29, 2025


Contribution Workflow

  1. Fork the Firebase repo and clone it.
  2. Add Upstream: git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
  3. Create Branch: git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
    • Where <feature-branch> is the name of the branch (e.g., add-tests-streamable).
  4. Regular workflow: Run style script and git add . && git commit -m "..."
  5. Push: git push origin <feature-branch>
  6. PR: Create a PR on GitHub, with base branch set tofirebase:streamable-functions
  7. Update fork feature branch (if needed):
git fetch upstream
git checkout <feature-branch>
git merge upstream/streamable-functions
git push origin <feature-branch>

eBlender and others added 30 commits December 19, 2024 14:32
Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
testing check.sh
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Add Json capabilities to parse an HTTP result back and forth.

Updating Unit tests.
Add doc for processResponseDataForStreamableContent.
Update func to have a callback.
Update UnitTests
Remove spaces.
Fetch Main branch.
Project clean up.
Updated to renamed code. From callableResultFromResponse to callableResult
Run style.sh
Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.
This file is not needed.
This file is not needed.
Add throws
Remove DO - CATCH
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Apple API Diff Report

Commit: b280b75
Last updated: Wed Jan 29 08:18 PST 2025
View workflow logs & download artifacts


FirebaseFunctions

Structures

Callable
[ADDED] stream(_:)
Swift:
+  public func stream ( _ data : Request ) -> AsyncThrowingStream < Response , Error >

…e network calls are done.

Co-authored-by: Eblen M <[email protected]>
Co-authored-by: Author: Nick Cooke <[email protected]>
eBlender and others added 4 commits January 29, 2025 10:31
Need to add UnitTests here.

Co-authored-by: Eblen M <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Eblen M <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Add new case for genStreamError

Co-authored-by: Eblen M <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants