-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Streamable functions #14395
Open
ncooke3
wants to merge
55
commits into
main
Choose a base branch
from
streamable-functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Streamable functions #14395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Add Json capabilities to parse an HTTP result back and forth. Updating Unit tests.
Cleanup
Add doc for processResponseDataForStreamableContent.
Update func to have a callback. Update UnitTests
Remove test.
Fetch Main branch.
…/firebase-ios-sdk into iOS-Stremable-Functions
Updated to renamed code. From callableResultFromResponse to callableResult
Run style.sh
Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.
Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Nick Cooke <[email protected]>
This file is not needed.
This file is not needed.
Add throws Remove DO - CATCH
Generated by 🚫 Danger |
Apple API Diff ReportCommit: b280b75 FirebaseFunctionsStructuresCallable[ADDED] stream(_:)Swift:
+ public func stream ( _ data : Request ) -> AsyncThrowingStream < Response , Error > |
…e network calls are done. Co-authored-by: Eblen M <[email protected]> Co-authored-by: Author: Nick Cooke <[email protected]>
Need to add UnitTests here. Co-authored-by: Eblen M <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Co-authored-by: Eblen M <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
Typo fix.
Add new case for genStreamError Co-authored-by: Eblen M <[email protected]> Co-authored-by: Nick Cooke <[email protected]>
818Nawaf
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Workflow
git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
<feature-branch>
is the name of the branch (e.g., add-tests-streamable).git add . && git commit -m "..."
git push origin <feature-branch>
firebase:streamable-functions