[rc-swift] ConfigRealtime #14299
Merged
[rc-swift] ConfigRealtime #14299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 13d4c70 FirebaseRemoteConfigClasses[MODIFIED] FIRRemoteConfigSettings[MODIFIED] FIRRemoteConfigSettingsSwift:
+ class RemoteConfigSettings : NSObject
- var minimumFetchInterval : TimeInterval { get set }
- var fetchTimeout : TimeInterval { get set }
Objective-C:
+ @interface FIRRemoteConfigSettings : NSObject
- @property ( nonatomic ) NSTimeInterval minimumFetchInterval ;
- @property ( nonatomic ) NSTimeInterval fetchTimeout ;FIRRemoteConfig[REMOVED] -initWithAppName:FIROptions:namespace:DBManager:configContent:userDefaults:analytics:configFetch:Swift:
- init ( appName : String , firOptions options : FIROptions , namespace FIRNamespace : String , dbManager DBManager : RCNConfigDBManager , configContent : RCNConfigContent , userDefaults : UserDefaults ?, analytics : ( any FIRAnalyticsInterop )?, configFetch : RCNConfigFetch ?)
Objective-C:
- - ( instancetype ) initWithAppName :( NSString * ) appName FIROptions :( FIROptions * ) options namespace :( NSString * ) FIRNamespace DBManager :( RCNConfigDBManager * ) DBManager configContent :( RCNConfigContent * ) configContent userDefaults :( nullable NSUserDefaults * ) userDefaults analytics :( nullable id < FIRAnalyticsInterop > ) analytics configFetch :( nullable RCNConfigFetch * ) configFetch ;[MODIFIED] -addOnConfigUpdateListener:Swift:
+ func addOnConfigUpdateListener ( remoteConfigUpdateCompletion listener : @escaping ( FIRRemoteConfigUpdate ?, ( any Error )?) -> Void ) -> FIRConfigUpdateListenerRegistration
- func addOnConfigUpdateListener ( remoteConfigUpdateCompletion listener : @escaping ( FIRRemoteConfigUpdate ?, ( any Error )?) -> Void ) -> ConfigUpdateListenerRegistration
Objective-C:
+ - ( FIRConfigUpdateListenerRegistration * _Nonnull ) addOnConfigUpdateListener : ( FIRRemoteConfigUpdateCompletion _Nonnull ) listener ;
- - ( FIRConfigUpdateListenerRegistration * _Nonnull ) addOnConfigUpdateListener : ( FIRRemoteConfigUpdateCompletion _Nonnull ) listener ;[ADDED] configRealtimeSwift:
+ var configRealtime : RCNConfigRealtime { get set }
Objective-C:
+ @property ( nonatomic , readwrite , strong , nonnull ) RCNConfigRealtime * configRealtime[ADDED] -initWithAppName:FIROptions:namespace:DBManager:configContent:userDefaults:analytics:configFetch:configRealtime:Swift:
+ init ( appName : String , firOptions options : FIROptions , namespace FIRNamespace : String , dbManager DBManager : RCNConfigDBManager , configContent : RCNConfigContent , userDefaults : UserDefaults ?, analytics : ( any FIRAnalyticsInterop )?, configFetch : RCNConfigFetch ?, configRealtime : RCNConfigRealtime ?)
Objective-C:
+ - ( instancetype ) initWithAppName :( NSString * ) appName FIROptions :( FIROptions * ) options namespace :( NSString * ) FIRNamespace DBManager :( RCNConfigDBManager * ) DBManager configContent :( RCNConfigContent * ) configContent userDefaults :( nullable NSUserDefaults * ) userDefaults analytics :( nullable id < FIRAnalyticsInterop > ) analytics configFetch :( nullable RCNConfigFetch * ) configFetch configRealtime :( nullable RCNConfigRealtime * ) configRealtime ;[REMOVED] FIRConfigUpdateListenerRegistration[REMOVED] FIRConfigUpdateListenerRegistrationSwift:
- class ConfigUpdateListenerRegistration : NSObject , @unchecked Sendable
- func remove ()
Objective-C:
- @interface FIRConfigUpdateListenerRegistration : NSObject
- - ( void ) remove ; |
paulb777
commented
Jan 2, 2025
| @@ -26,15 +26,11 @@ import Foundation | |||
| // TODO(ncooke3): Once Obj-C tests are ported, all `public` access modifers can be removed. | |||
|
|
|||
| #if RCN_STAGING_SERVER | |||
| private let serverURLDomain = "https://staging-firebaseremoteconfig.sandbox.googleapis.com" | |||
| private let serverURLDomain = "staging-firebaseremoteconfig.sandbox.googleapis.com" | |||
There was a problem hiding this comment.
Now using URLComponents to construct the URL
| #endif | ||
| private let serverURLVersion = "/v1" |
| @@ -741,29 +728,6 @@ extension Installations: InstallationsProtocol {} | |||
| dataTask.resume() | |||
| } | |||
|
|
|||
| private func constructServerURL() -> String { | |||
ncooke3
reviewed
Jan 3, 2025
ncooke3
reviewed
Jan 3, 2025
ncooke3
reviewed
Jan 3, 2025
ncooke3
reviewed
Jan 3, 2025
| self.propagateErrors(error) | ||
| return | ||
| } | ||
| if self.canMakeConnection() { |
There was a problem hiding this comment.
optional, but consider moving this up to the guard condition:
guard self.canMakeConnection(), self.remainingRetryCount > 0 else { ... }
There was a problem hiding this comment.
Not sure about that, since it could introduce more errors when there are no listeners?
ncooke3
reviewed
Jan 3, 2025
paulb777
commented
Jan 3, 2025
| self.propagateErrors(error) | ||
| return | ||
| } | ||
| if self.canMakeConnection() { |
There was a problem hiding this comment.
Not sure about that, since it could introduce more errors when there are no listeners?
Co-authored-by: Nick Cooke <[email protected]>
ncooke3
reviewed
Jan 3, 2025
ncooke3
approved these changes
Jan 3, 2025
|
Merging here. @ncooke3 will address remaining comments in a subsequent PR. |
paulb777
added a commit
that referenced
this pull request
Jan 17, 2025
Co-authored-by: Nick Cooke <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial Swift implementation of ConfigRealtime.
Some of the implementation was borrowed from similar implementations in ConfigFetch and a Utils directory was started to avoid copying shared functions.
Most tests are disabled and on deeper analysis far from sufficient. They should still be implemented in Swift once we have everything in Swift. However, integration testing will be necessary since most of the tricky code is related to URLSession management for which the unit tests are especially lacking.