Integration tests Setup and Initial tests for Scalars #13473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
dconeybe
requested changes
Aug 9, 2024
dconeybe
approved these changes
Aug 12, 2024
FirebaseDataConnect/Tests/Resources/fdc-kitchensink/dataconnect/default/connector.yaml
Outdated
Show resolved
Hide resolved
paulb777
approved these changes
Aug 12, 2024
|
|
||
| func createScalarBoundaryMutationRef(id: UUID, | ||
|
|
||
| maxNumber: Int, |
There was a problem hiding this comment.
nit: Many extra blank lines in this file.
There was a problem hiding this comment.
This is generated code. I ran it via our style script and this is the cleaned up version.
There was a problem hiding this comment.
Will need to work on fixing the generation to reduce blank lines. Some of these won't removed by swift formatting.
|
And fix the check CI job |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for Integration tests and added intial set of Scalar tests.
More tests will be added later.