Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue calling DataSnapshot methods with null data #1661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rhodgkins
Copy link
Contributor

@rhodgkins rhodgkins commented Jan 13, 2025

Description

Fixes firebase/firebase-functions-test#254

Fix is similar to the check in #exists():

if (typeof val === "undefined" || val === null) {

@inlined
Copy link
Member

inlined commented Jan 22, 2025

@taeold IIUC this is a straight bugfix, but I wanted to double check that you don't consider this a breaking change.

@inlined inlined requested a review from taeold January 22, 2025 01:05
@taeold
Copy link
Contributor

taeold commented Jan 24, 2025

Feels like this is a good change and not breaking.

IIUC the change would only break if the traversing the full path instead of short-circuiting somehow had a side effect that was worthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants