Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GMavenService #6644

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement GMavenService #6644

wants to merge 3 commits into from

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jan 24, 2025

Per b/392134866,

This implements a centralized interface for communicating with GMaven called GMavenService. This service implements the gradle build-service interface to provide proper parallel access, and keeps local ConcurrentHashMap instances to cache responses.

Cached responses are on a per-build basis, to avoid improper caching of dynamic data. That is, given any build- all tasks that utilize GMavenService will share the responses from GMaven; even within a parallel environment. But if the tasks are considered out-of-date and are ran again, then new requests will be made to the GMaven backend.

Tests and documentation are provided for everything added as well.

Note that while this PR implements GMavenService- it does not refactor the existing GMavenHelper and RepositoryClient usages to use it. That will occur in subsequent PRs, as to avoid polluting this PR. Furthermore, while there are no tests for PomElement directly- in a future PR that includes tests for bom generation, PomElement will be tested as a by-product.

This PR also fixes the following:

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.3

Copy link
Contributor

plugins test results

49 tests   49 ✅  3m 9s ⏱️
 9 suites   0 💤
 9 files     0 ❌

Results for commit 030c1a4.

Copy link
Contributor

Test Results

 1 034 files  ±0   1 034 suites  ±0   34m 23s ⏱️ +27s
 5 888 tests ±0   5 866 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 839 runs  ±0  11 795 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 030c1a4. ± Comparison against base commit 0ce193f.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (0ce193f) to 50.21% (f955f79) by +0.04%.

    FilenameBase (0ce193f)Merge (f955f79)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-messaging

    Overall coverage changed from 84.23% (0ce193f) to 84.04% (f955f79) by -0.19%.

    FilenameBase (0ce193f)Merge (f955f79)Diff
    FirebaseMessaging.java76.80%76.00%-0.80%
    Metadata.java41.27%36.51%-4.76%
  • firebase-firestore

    FilenameBase (0ce193f)Merge (f955f79)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LbcSd7M01n.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants