feat(fdc): Add support for Data Connect Impersonation #2844
+260
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanedey
requested review from
lahirumaramba,
maneesht and
aashishpatil-g
lahirumaramba
approved these changes
Feb 10, 2025
| // @public | ||
| export interface ImpersonateAuthenticated { | ||
| // Warning: (ae-forgotten-export) The symbol "DecodedIdToken" needs to be exported by the entry point index.d.ts | ||
| authClaims: Partial<DecodedIdToken>; |
There was a problem hiding this comment.
Should this type be re-exported from src/data-connect/index.ts?
| .should.eventually.be.rejected.and.has.property('code', 'data-connect/unauthenticated'); | ||
| }); | ||
|
|
||
| it('executeGraphql() successfully executes an impersonated query with non-existing authenticated claims', |
There was a problem hiding this comment.
nit: maybe reword this to: "should return an empty list for an impersonated query with non-existing authenticated claims"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.