feat: move from SmartLock to CredentialManager #2180
Conversation
| - uses: actions/checkout@v2 | ||
| - name: set up JDK 11 |
There was a problem hiding this comment.
| - name: set up JDK 11 | |
| - name: set up JDK 17 |
| implementation("androidx.core:core-ktx:1.10.1") | ||
|
|
||
| implementation(Config.Libs.Androidx.lifecycleExtensions) | ||
| implementation("androidx.core:core-ktx:1.13.1") |
There was a problem hiding this comment.
We seem to have the same core-ktx dependency listed twice with different versions?
Can we remove the older version?
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip | |||
There was a problem hiding this comment.
Do we need all? I tend to use bin for the small download size.
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip | |
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip |
| plugins { | ||
| id "com.gradle.enterprise" version "3.3.3" | ||
| id "org.jetbrains.dokka" version "2.0.0" apply false |
There was a problem hiding this comment.
Are we using dokka now, or is this for later? :)
| const val min = 16 | ||
| const val compile = 34 | ||
| const val target = 34 | ||
| const val min = 21 |
There was a problem hiding this comment.
The latest version of Auth requires minSdk 23, so we might have to bump this one a little higher 😅
| @@ -5,6 +5,7 @@ buildscript { | |||
| google() | |||
| mavenCentral() | |||
| mavenLocal() | |||
| maven("https://oss.jfrog.org/artifactory/oss-release-local") | |||
There was a problem hiding this comment.
I assume we use this repo for build-info-extractor-gradle ?
I have no idea why we use that plugin, can we maybe add a comment here to say that this line is needed for that plugin? That way we removed them altogether if we find out that it is not needed.
|
|
||
| viewModelScope.launch { | ||
| try { | ||
| credentialManager.createCredential(activity, request) |
There was a problem hiding this comment.
Looks like createCredential() takes Context as argument. Maybe we can pass that to saveCredentials() instead of activity: androidx.activity.ComponentActivity ?
Also, do we care about the result of createCredential() ? it seems like we're ignoring it right now.
There was a problem hiding this comment.
From what I understood, we don't need to get the result - if createCredential() succeeds, we've safely saved the user's password. But that brings me to another question: (out of curiosity) what's in the result of this call?
|
|
||
| class CredentialSaveActivity : InvisibleActivityBase() { | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
Can we leave companions objects at the end of classes, conforming to Kotlin's coding conventions?
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:
./gradlew checkto ensure the Travis build passes.