Dataset Collector #1, Egorova Anastasia - 19FPL2 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorova-ai19-2
added
the
Review Required
dmitry-uraev
added
🕷️Crawler accepted
and removed
Review Required
egorova-ai19-2
added
the
Review Required
dmitry-uraev
reviewed
Apr 2, 2021
pipeline.py
Outdated
| return "MorphologicalToken instance here" | ||
| return f'{self.normalized_form}<{self.mystem_tags}>({self.pymorphy_tags})' | ||
|
|
||
| def public_method(self): |
There was a problem hiding this comment.
You try to fix lint by using unnecessary stubs. Actually, it would be better to change lint params. In that case lint check would not pay any attention to "to few public methods" case. And you would not have to change given interface. If you want, you may fix this one. Tip: pylint settings are in .pylintrc files:)
There was a problem hiding this comment.
Thank you for the tip) I've fixed this error.
| pass | ||
| self.original_word = original_word | ||
| self.normalized_form = normalized_form | ||
| self.mystem_tags = '' |
There was a problem hiding this comment.
why str? may be list? or other data type
pipeline.py
Outdated
|
|
||
| def get_articles(self): | ||
| """ | ||
| Returns storage params | ||
| """ | ||
| return self._storage | ||
|
|
||
| def public_method(self): |
| @@ -2,7 +2,13 @@ | |||
| Pipeline for text processing implementation | |||
| """ | |||
|
|
|||
| import os | |||
| from pathlib import Path, PurePath | |||
pipeline.py
Outdated
|
|
||
| return tokens | ||
|
|
||
| def public_method(self): |
dmitry-uraev
removed
the
Review Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.