Dataset Collector #1, Zelekson Daniil - 19FPL1 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-uraev
suggested changes
Mar 9, 2021
| @@ -1,32 +1,35 @@ | |||
| """ | |||
There was a problem hiding this comment.
Oh, finally. I was waiting for this one to be created.
scrapper.py
Outdated
|
|
||
| class IncorrectURLError(Exception): | ||
| """ | ||
| Custom error | ||
| """ | ||
| pass | ||
| # def __init__(self, ): |
There was a problem hiding this comment.
nice constructor initialization
|
|
||
|
|
||
| class NumberOfArticlesOutOfRangeError(Exception): | ||
| """ | ||
| Custom error | ||
| """ | ||
|
|
There was a problem hiding this comment.
what is this line targeted for?
|
|
||
| class IncorrectNumberOfArticlesError(Exception): | ||
| """ | ||
| Custom error | ||
| """ | ||
|
|
scrapper.py
Outdated
| @@ -36,13 +39,15 @@ def find_articles(self): | |||
| """ | |||
| Finds articles | |||
| """ | |||
| pass | |||
| raise IncorrectURLError | |||
scrapper.py
Outdated
|
|
||
| def get_search_urls(self): | ||
| """ | ||
| Returns seed_urls param | ||
| """ | ||
| pass | ||
| return seed_urls |
dmitry-uraev
added
the
Changes required
dmitry-uraev
added
Missed crawler deadline
Changes required
|
Oh! It was an accident! |
dmitry-uraev
suggested changes
Mar 30, 2021
dmitry-uraev
suggested changes
Apr 2, 2021
| @@ -0,0 +1,86 @@ | |||
| argon2-cffi==20.1.0 | |||
| wrapt==1.12.1 | ||
| xlrd==1.2.0 | ||
| xlwt==1.3.0 | ||
| zipp==3.4.1 |
There was a problem hiding this comment.
You used all these? Will you share with me on Monday?
mydate_framework.py
Outdated
| @@ -0,0 +1,26 @@ | |||
| def get_month(m): | |||
There was a problem hiding this comment.
Nice framework, but it is not quite a framework) It is just one module with one function
| @@ -0,0 +1,3 @@ | |||
| beautifulsoup4 | |||
There was a problem hiding this comment.
better specify version here for consistency
scrapper.py
Outdated
| @@ -27,71 +53,164 @@ class UnknownConfigError(Exception): | |||
| """ | |||
|
|
|||
|
|
|||
| lw = LinkWorker('', '') | |||
There was a problem hiding this comment.
we need it to get absolute link from relative
Suggested change
| lw = LinkWorker('', '') | |
| lw = LinkWorker('', '') |
scrapper.py
Outdated
| arr = date_str.split(" ") | ||
| arr[0] = arr[0][0:len(arr[0]) - 1] | ||
| return arr[3] + '-' + get_month(arr[2]) + '-' + arr[1] + ' ' + arr[0] + ':00' | ||
| except Exception: |
There was a problem hiding this comment.
you may specify particular error here
| self.article.title = article_soup.find('h1').text | ||
| except Exception: | ||
| self.article.title = 'NOT FOUND' | ||
| self.article.topics.append(self.article.title) | ||
|
|
||
| @staticmethod | ||
| def unify_date_format(date_str): |
dmitry-uraev
added
Missed pipeline deadline
🕷️Crawler accepted
and removed
Changes required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.