Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Collector #1, Kazyulina Marina - 19FPL1 #42
base: main
Are you sure you want to change the base?
Dataset Collector #1, Kazyulina Marina - 19FPL1 #42
Changes from all commits
3261adb
f471f4a
742558c
dbcaa4d
0c35e77
8a09da7
6fee8b3
aafdefd
0cc3a91
e3e8eda
1355f14
56fbb38
cfeae30
39e8923
6e5ec03
4733964
ead1f17
cf7e97b
54a49ed
2854e58
358f74b
f7aa7f6
9f45627
e75381c
225e72a
dc7c08a
b147b47
d09c9f3
731448c
fd304d7
d7afc62
23182bb
0ee4d5e
f1a59fa
631ec92
21e4fd8
1b73cb3
7a7a01f
19ff11d
c30d85a
c58526b
0a9c9fe
db17bf6
7ea4755
7e85982
a83469e
27280a0
4efc05d
b45ee40
5c3a245
f6c7034
b8399cc
b8dc298
96f7e8e
ff570e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it is seed url or any other configuration of the crawler, then use configuration file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it is the beginning of every url in my sourse
you see, as in many webpages, the href tags in my source are filled with the continuation of the url, emitting the 'https://burunen.ru', so each and every time i try to request the link i found automatically i have to concatenate it with this beginning first.
i thought about making an additional attribute to the Crawler class (something like self.url_start = "), but then i decided that if it is constant, it should be placed among other constants... am i wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you find a way to directly get files by the given name template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too broad try/except resulting in the following: you have mystem reported you some information, pymorphy failed -> what would be the result ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually it is mystem that fails
pymorphy, on the contrary, has a tag for exceptional cases so there is no chance of getting IndexError with it
but it is a valid correction that i dont even check if it is recognised as unknown here
i'll fix it thanks