Dataset Collector #1, Bykova Ekaterina - 19FPL2 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-uraev
suggested changes
Mar 9, 2021
dmitry-uraev
added
the
Changes required
dmitry-uraev
suggested changes
Mar 11, 2021
| @@ -7,3 +7,6 @@ | |||
| PROJECT_ROOT = os.path.dirname(os.path.realpath(__file__)) | |||
| ASSETS_PATH = os.path.join(PROJECT_ROOT, 'tmp', 'articles') | |||
| CRAWLER_CONFIG_PATH = os.path.join(PROJECT_ROOT, 'crawler_config.json') | |||
| HEADERS = { | |||
crawler_config.json
Outdated
| "max_number_articles_to_get_from_one_seed": 0 | ||
| "base_urls": ["https://express-kamchatka1.ru/sobytiya.html"], | ||
| "total_articles_to_find_and_parse": 15, | ||
| "max_number_articles_to_get_from_one_seed": 15 |
scrapper.py
Outdated
| from datetime import datetime | ||
| from bs4 import BeautifulSoup | ||
| from article import Article | ||
| from constants import CRAWLER_CONFIG_PATH |
There was a problem hiding this comment.
you may import them in one line
scrapper.py
Outdated
| response = requests.get(url, headers=HEADERS) | ||
| if response: | ||
| content = response.text | ||
| links = self._extract_url(BeautifulSoup(content, 'html.parser')) |
There was a problem hiding this comment.
you may try "lxml" option here
|
Nice commits namings BTW) |
|
'puk' |
ffmiil
removed
the
Changes required
dmitry-uraev
added
Changes required
dmitry-uraev
reviewed
Apr 2, 2021
There was a problem hiding this comment.
I see you have different sites specified in crawler and in our table: http://express-kamchatka1.ru/ and https://www.e1.ru/news/ is this correct?
dmitry-uraev
added
🏆 Pipeline accepted
🕷️Crawler accepted
and removed
Changes required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.