Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Collector #1, Chudinova Alla - 19FPL2 #37

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

x-ae-a-12
Copy link

No description provided.

Copy link
Contributor

@dmitry-uraev dmitry-uraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It it time to start implementing something here. Or implementing some essays may be?)

scrapper.py Outdated
response = requests.get('')
print('')
sleep (5) #import time first
response = request.get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's start to implement code. I think it's a good time.

@@ -1,5 +1,5 @@
# Target score for scrapper.py:
6
8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that s good switch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that s good switch.

No, I do not think so. It is eminent I'd better switch to 4 or 6 later.

scrapper.py Outdated
@@ -32,7 +32,7 @@ class Crawler:
Crawler implementation
"""
def __init__(self, seed_urls: list, max_articles: int):
pass
self.seed_urls = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize other params in the constructor

scrapper.py Outdated
print('')
sleep (5) #import time first
response = request.get
#ILY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@dmitry-uraev dmitry-uraev self-assigned this Mar 6, 2021
Copy link
Contributor

@dmitry-uraev dmitry-uraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is right time to implement something. The deadline is coming.

@dmitry-uraev dmitry-uraev added Review Required You are ready for next iteration of review Changes required Reviewer has comments you need to apply. Once you are ready, replace it with Review Required and removed Review Required You are ready for next iteration of review labels Mar 9, 2021
I/ve done it with desktop app
@x-ae-a-12
Copy link
Author

It is right time to implement something. The deadline is coming.

ok

I wish I had green pr, mais on va le voir...
Plaisir de l'article.py ne dure qu'un moment, chagrin du scrapper dure toute la vie
@x-ae-a-12 x-ae-a-12 added the Review Required You are ready for next iteration of review label Mar 10, 2021
Changed a line in my code in order to pass all (i hope) checks
Copy link
Contributor

@dmitry-uraev dmitry-uraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like this realisation. We may add some styling corrections, but overall - super.

@dmitry-uraev dmitry-uraev added 🕷️Crawler accepted and removed Changes required Reviewer has comments you need to apply. Once you are ready, replace it with Review Required Review Required You are ready for next iteration of review labels Mar 11, 2021
@dmitry-uraev
Copy link
Contributor

Good! Not best from the styling side, but acceptable for 8

@x-ae-a-12
Copy link
Author

Good! Not best from the styling side, but acceptable for 8

ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants