-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Collector #1, Chudinova Alla - 19FPL2 #37
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It it time to start implementing something here. Or implementing some essays may be?)
scrapper.py
Outdated
response = requests.get('') | ||
print('') | ||
sleep (5) #import time first | ||
response = request.get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's start to implement code. I think it's a good time.
@@ -1,5 +1,5 @@ | |||
# Target score for scrapper.py: | |||
6 | |||
8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that s good switch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that s good switch.
No, I do not think so. It is eminent I'd better switch to 4 or 6 later.
scrapper.py
Outdated
@@ -32,7 +32,7 @@ class Crawler: | |||
Crawler implementation | |||
""" | |||
def __init__(self, seed_urls: list, max_articles: int): | |||
pass | |||
self.seed_urls = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initialize other params in the constructor
scrapper.py
Outdated
print('') | ||
sleep (5) #import time first | ||
response = request.get | ||
#ILY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is right time to implement something. The deadline is coming.
I/ve done it with desktop app
ok |
I wish I had green pr, mais on va le voir...
Plaisir de l'article.py ne dure qu'un moment, chagrin du scrapper dure toute la vie
Changed a line in my code in order to pass all (i hope) checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I like this realisation. We may add some styling corrections, but overall - super.
i need green pr
Good! Not best from the styling side, but acceptable for 8 |
ok, thank you. |
No description provided.