Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset Collector #1, Isaichkina Anastasia - 19FPL1 #34

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
Open

Dataset Collector #1, Isaichkina Anastasia - 19FPL1 #34

wants to merge 71 commits into from

Conversation

anmyfe
Copy link

@anmyfe anmyfe commented Mar 4, 2021

No description provided.

@demid5111 demid5111 self-assigned this Mar 5, 2021
demid5111
demid5111 requested changes Mar 5, 2021
View reviewed changes
Copy link
Member

@demid5111 demid5111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes so far - hurry up - you have only two weeks before 1st milestone

scrapper.py Outdated Show resolved Hide resolved
@anmyfe anmyfe added the Review Required You are ready for next iteration of review label Mar 9, 2021
demid5111
demid5111 requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@demid5111 demid5111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very well, almost done

article.py Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
scrapper.py Show resolved Hide resolved
scrapper.py Outdated Show resolved Hide resolved
scrapper.py Show resolved Hide resolved
scrapper.py Outdated Show resolved Hide resolved
scrapper.py Outdated
conf = json.load(file)

if 'base_urls' not in conf or not isinstance(conf['base_urls'], list) or\
not all([isinstance(link, str) for link in conf['base_urls']]):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better check for urls is required

@demid5111 demid5111 added Changes required Reviewer has comments you need to apply. Once you are ready, replace it with Review Required and removed Review Required You are ready for next iteration of review labels Mar 12, 2021
@anmyfe anmyfe removed the Changes required Reviewer has comments you need to apply. Once you are ready, replace it with Review Required label Mar 14, 2021
@anmyfe anmyfe added Review Required You are ready for next iteration of review and removed Changes required Reviewer has comments you need to apply. Once you are ready, replace it with Review Required labels Apr 4, 2021
demid5111
demid5111 requested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@demid5111 demid5111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more work is required

pipeline.py Outdated Show resolved Hide resolved
pipeline.py Outdated Show resolved Hide resolved
@demid5111 demid5111 added 🏆 Pipeline accepted and removed Review Required You are ready for next iteration of review labels Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demid5111 demid5111 demid5111 requested changes

Assignees

@demid5111 demid5111

Labels
🕷️Crawler accepted Demidovskij A.V. 🏆 Pipeline accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmyfe @demid5111 @dmitry-uraev