Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Don't merge] Snapshot issues #1196

Closed
wants to merge 7 commits into from
Closed

[Don't merge] Snapshot issues #1196

wants to merge 7 commits into from

Conversation

bstien
Copy link
Member

@bstien bstien commented Feb 1, 2023 •
edited
Loading

Why?

I'm using this branch to test snapshot issues in #1195.

What's tested?

What Does test succeed?
Remove snapshot reference image ❌
Add a fullscreen black cover to BadgeDemoView ✅
Retake snapshot on iPhone 13 Max Pro, instead of iPhone X ❌

@bstien bstien changed the base branch from master to refactor/realestate-redesign February 1, 2023 14:56
@bstien
Copy link
Member Author

bstien commented Feb 2, 2023

The issue is identified and fixed in #1197

@bstien bstien closed this Feb 2, 2023
@bstien bstien deleted the snapshot-issues branch February 2, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bstien