Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main swift-snapshot repo. #2

Closed
wants to merge 1 commit into from
Closed

Conversation

BjornRuud
Copy link
Contributor

The fork isn't necessary anymore as the main repo has been updated with a perceptual precision parameter for the diff.

@BjornRuud BjornRuud requested a review from bstien December 11, 2023 15:43
@bstien
Copy link
Member

bstien commented Dec 11, 2023

Yes, but Metal (GPU) is required to use that, which we don't have on Travis/CircleCI. If Metal is not available the tests will always succeed, even when it shouldn't.

We need something like this PR to be merged before we can switch away from the fork:
pointfreeco/swift-snapshot-testing#666

@BjornRuud
Copy link
Contributor Author

Fork is necessary, will find and change the places that are not using the fork.

@BjornRuud BjornRuud closed this Dec 12, 2023
@BjornRuud BjornRuud deleted the update-swift-snapshot branch December 12, 2023 09:50
@adriansergheev
Copy link
Collaborator

Yes, but Metal (GPU) is required to use that, which we don't have on Travis/CircleCI. If Metal is not available the tests will always succeed, even when it shouldn't.

We need something like this PR to be merged before we can switch away from the fork: pointfreeco/swift-snapshot-testing#666

this seems to be kept updated with the latest main from maintainers
https://github.com/Frameio/swift-snapshot-testing/tree/non-metal-image-comparison

the one used used now is 80 commits behind
@BjornRuud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants