Merge pull request #52 from finddx/featureOSDates

rm all na cols
finddx · Aug 8, 2024 · 9565b28 · 9565b28
2 parents abe837f + 5631958
commit 9565b28
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/R/get_bulk_query.R b/R/get_bulk_query.R
@@ -68,7 +68,8 @@ get_bulk_query <- function(auth_response,
 
   # Remove  0 column DFs
   results_list <- results_list[sapply(results_list, function(x) !is.null(x))]
-
+  #findBiobankR::rm_all_na_col
+  #results_list <- lapply(results_list, findBiobankR::rm_all_na_col)
   # Return the results as a single data frame
   df_results = data.table::rbindlist(results_list, fill = T) 
 

diff --git a/R/parse_os_response.R b/R/parse_os_response.R
@@ -32,7 +32,7 @@ parse_os_response <- function(response, parse_data_function, skip_date_convertio
 
     if(inherits(df, "data.frame") & !skip_date_convertion){
 
-      
+     df = rm_all_na_col(df)
      df =  timestamp_to_date(df, ...)
 
     }

diff --git a/dev/OpenSpecimenAPI.Rmd b/dev/OpenSpecimenAPI.Rmd
@@ -337,7 +337,7 @@ parse_os_response <- function(response, parse_data_function, skip_date_convertio
     
     if(inherits(df, "data.frame") & !skip_date_convertion){
       
-      
+     df = rm_all_na_col(df)
      df =  timestamp_to_date(df, ...)
      
     }
@@ -582,7 +582,8 @@ get_bulk_query <- function(auth_response,
   
   # Remove  0 column DFs
   results_list <- results_list[sapply(results_list, function(x) !is.null(x))]
-  
+  #findBiobankR::rm_all_na_col
+  #results_list <- lapply(results_list, findBiobankR::rm_all_na_col)
   # Return the results as a single data frame
   df_results = data.table::rbindlist(results_list, fill = T)
-Original file line number
+Diff line change
@@ Expand Up @@
         if(inherits(df, "data.frame") & !skip_date_convertion){
+         df = rm_all_na_col(df)
          df =  timestamp_to_date(df, ...)
         }
@@ Expand Down @@