[CODE REVIEW]Feature/SPRO-48 Support Braintree Payment Extensions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytorbyk
requested changes
Jan 4, 2022
Observer/DataAssignObserver.php
Outdated
Comment on lines
60
to
64
| $stateData = $paymentInfo->getAdditionalInformation('stateData'); // AssignObserver::STATE_DATA | ||
| if (is_array($stateData)) { | ||
| $stateData['storePaymentMethod'] = true; // AssignObserver::STORE_PAYMENT_METHOD | ||
| $paymentInfo->setAdditionalInformation('stateData', $stateData); | ||
| } |
There was a problem hiding this comment.
Are you sure it is related to Braintree?
Comment on lines
+76
to
+68
| $result = $this->getPaymentNonceCommand->execute( | ||
| ['public_hash' => $publicHash, 'customer_id' => $customerId] | ||
| )->get(); |
There was a problem hiding this comment.
We don't need to fetch paymentMethodNonce, we already have it: $paymentMethodToken
There was a problem hiding this comment.
Just checked; we do need the nonce
Comment on lines
+82
to
+75
| $paymentModel->setAdditionalInformation( | ||
| DataAssignObserver::PAYMENT_METHOD_NONCE, | ||
| $result['paymentMethodNonce'] | ||
| ); |
There was a problem hiding this comment.
Suggested change
| $paymentModel->setAdditionalInformation( | |
| DataAssignObserver::PAYMENT_METHOD_NONCE, | |
| $result['paymentMethodNonce'] | |
| ); | |
| $paymentModel->setAdditionalInformation(DataAssignObserver::PAYMENT_METHOD_NONCE, $paymentMethodToken); |
composer.json
Outdated
| "authors": [ | ||
| { | ||
| "name": "SUBSCRIBE PRO INC", | ||
| "homepage": "http://www.subscribepro.com" |
There was a problem hiding this comment.
Please, update to https://www.subscribepro.com
| "Swarming\\SubscribeProBraintree\\": "" | ||
| } | ||
| } | ||
| } |
Dmitry-Pryshchepa
force-pushed
the
feature/SPRO-48
branch
from
8fbd0e6 to
0db007d
Compare
Remove DataAssignObserver, rework TokenAssigner observer, refine composer.json
Dmitry-Pryshchepa
force-pushed
the
feature/SPRO-48
branch
from
0db007d to
3c01f69
Compare
ytorbyk
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.