Skip to content

Commit

Permalink
ci(release): fix the create release issue workflow (#12826)
Browse files Browse the repository at this point in the history
ci: fix the create release issue workflow
  • Loading branch information
galargh authored Jan 13, 2025
1 parent 4a66850 commit b83bf69
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/create-release-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,11 @@ on:
rc1-date:
description: "What's the expected shipping date for RC1?"
required: false
default: "TBD"
stable-date:
description: "What's the expected shipping date for the stable release?"
required: false
default: "TBD"

defaults:
run:
Expand All @@ -58,7 +60,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
run: |
go run cmd/release/main.go create-issue \
--create-on-github true \
--create-on-github=true \
--type "${{ github.event.inputs.type }}" \
--tag "${{ github.event.inputs.tag }}" \
--level "${{ github.event.inputs.level }}" \
Expand Down
3 changes: 2 additions & 1 deletion cmd/release/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,9 @@ func main() {
}
}

rc1Date := c.String("rc1-date")
releaseDateStringRegexp := regexp.MustCompile(releaseDateStringPattern)

rc1Date := c.String("rc1-date")
if rc1Date != "TBD" {
matches := releaseDateStringRegexp.FindStringSubmatch(rc1Date)
if matches == nil {
Expand Down

0 comments on commit b83bf69

Please sign in to comment.