Skip to content

Commit

Permalink
Update composer.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@danharrin
danharrin authored Dec 3, 2023
1 parent bd6ce7e commit 829e288
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/actions/composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"illuminate/contracts": "^10.0",
"illuminate/database": "^10.0",
"illuminate/support": "^10.0",
"league/csv": "^9.11",
"league/csv": "9.11.0",
"spatie/laravel-package-tools": "^1.9"
},
"autoload": {
Expand Down

3 comments on commit 829e288

@rossbearman
Copy link
Contributor

@rossbearman rossbearman commented on 829e288 Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danharrin, why is league/csv being pinned to the exact 9.11.0 release, rather than ^9.11?

9.11 was released on September 23 and there have been three further releases since then. This locks anyone using league/csv on a project with Filament to that specific version.

EDIT: Found #10002 which is the reason for this being introduced.

@danharrin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can confirm that the issue was since fixed, then we can unlock it

@rossbearman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move this discussion to #10002, I'm not familiar with the issue that caused it to be pinned, but a quick look suggests this may need to be fixed in Filament.

Please sign in to comment.